Commit 1720e7b4 authored by Mario Limonciello's avatar Mario Limonciello Committed by Philip Withnall
Browse files

fwupd: add some missing instances of error conversion

This should prevent FwupdError domain from leaking up to the GUI.
Suggested-by: default avatarMilan Crha <>
Signed-off-by: default avatarMario Limonciello <>
parent b0057000
......@@ -225,6 +225,7 @@ gs_plugin_setup (GsPlugin *plugin, GCancellable *cancellable, GError **error)
/* we know the runtime daemon version now */
fwupd_client_set_user_agent_for_package (priv->client, PACKAGE_NAME, PACKAGE_VERSION);
if (!fwupd_client_ensure_networking (priv->client, error)) {
gs_plugin_fwupd_error_convert (error);
g_prefix_error (error, "Failed to setup networking: ");
return FALSE;
......@@ -760,8 +761,10 @@ gs_plugin_refresh (GsPlugin *plugin,
/* get the list of enabled remotes */
remotes = fwupd_client_get_remotes (priv->client, cancellable, error);
if (remotes == NULL)
if (remotes == NULL) {
gs_plugin_fwupd_error_convert (error);
return FALSE;
for (guint i = 0; i < remotes->len; i++) {
FwupdRemote *remote = g_ptr_array_index (remotes, i);
if (!fwupd_remote_get_enabled (remote))
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment