1. 24 Nov, 2014 1 commit
  2. 18 Nov, 2014 1 commit
  3. 17 Nov, 2014 1 commit
  4. 06 Nov, 2014 2 commits
  5. 03 Nov, 2014 1 commit
  6. 29 Oct, 2014 1 commit
  7. 24 Oct, 2014 4 commits
  8. 21 Oct, 2014 6 commits
  9. 13 Oct, 2014 2 commits
  10. 12 Oct, 2014 1 commit
  11. 10 Oct, 2014 4 commits
  12. 09 Oct, 2014 3 commits
    • Kalev Lember's avatar
      trivial: Move a debug statement · 54d0b21d
      Kalev Lember authored
      Show app debug after having refined the app and we have all the details,
      not before.
      54d0b21d
    • Kalev Lember's avatar
      search: Don't ignore duplicate searches · 57c08941
      Kalev Lember authored
      Otherwise searching for the same string twice in gnome-shell leads to
      the details page not coming up the second time.
      57c08941
    • Kalev Lember's avatar
      Fix another race with displaying shell search provider results · 333af2ce
      Kalev Lember authored
      Another race that caused us to come up with the search view displayed,
      instead of the details view.
      
      We were getting the delayed "search-changed" signal callback after
      having already switched to the details view. If the computer was fast
      enough and managed to launch the details view in 150 ms, then the
      "search-changed" signal handler ran after that and caused us to switch
      back to the search view.
      
      Fix this by ignoring the next "search-changed" signal.
      333af2ce
  13. 06 Oct, 2014 4 commits
  14. 05 Oct, 2014 9 commits
    • Kalev Lember's avatar
      Don't warn for cancelled operations · 836c6105
      Kalev Lember authored
      Check if the error matches with G_IO_ERROR_CANCELLED and avoid emitting
      warnings in that case.
      836c6105
    • Kalev Lember's avatar
      plugin loader: Set the return-on-cancel flag for all threaded tasks · 59ae161d
      Kalev Lember authored
      This ensures that we get an immediate synchronous callback when we call
      g_cancellable_cancel. Being able to rely on that makes the calling code
      simpler and easier to understand.
      59ae161d
    • Kalev Lember's avatar
      sources dialog: Do teardown in dispose, instead of finalize · c6043950
      Kalev Lember authored
      g_cancellable_cancel can lead to a callback from the async task. Doing
      it in finalize is too late, since the template children teardown has
      already happened at that point and we'd crash dereferencing NULL
      pointers in get_sources_cb callback.
      
      Fix this by moving the g_cancellable_cancel() call and the rest of our
      teardown code to the dispose handler, so that it runs before the
      template children destruction.
      c6043950
    • Kalev Lember's avatar
      Destroy the sources dialog when it's closed · 5fc866d1
      Kalev Lember authored
      5fc866d1
    • Kalev Lember's avatar
      Fix a race with displaying results from shell search provider · a69e7792
      Kalev Lember authored
      Clicking on an app in gnome-shell search results is supposed to bring up
      the details page for that app, with the back button leading to the
      search page, pre-populated with the same search that was done in
      gnome-shell.
      
      The code for this was all there, but it rarely worked properly because
      we'd spawn two parallel async processes, one to switch to the search
      page, and another one to switch to the details page. Whichever finished
      last was the one that the user actually saw.
      
      Fix this by properly chaining the async operations so that we'd always
      end up on the details page.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=735798
      a69e7792
    • Kalev Lember's avatar
      Get rid of last two g_cancellable_reset uses · de2f1828
      Kalev Lember authored
      It's safer to create new cancellables each time instead of resetting the
      existing ones.
      de2f1828
    • Kalev Lember's avatar
      appstream plugin: Don't allow cancelling plugin startup · 5483adbc
      Kalev Lember authored
      We were hitting a concurrency bug where quickly typing "software" into
      shell overview search and hitting enter would bring up a non-working
      gnome-software.
      
      The cause turned out to be the shell search provider starting a search
      on the "software" string, which in turn started appstream database
      parsing in the appstream plugin. However, quickly hitting enter would
      cancel the current search, and also cancel the database parsing midway,
      leaving us without appstream data in the GUI.
      
      Fix this by making the database parsing and appstream plugin startup
      uncancellable.
      5483adbc
    • Kalev Lember's avatar
      shell search provider: Rewrite concurrent search handling logic · 27588054
      Kalev Lember authored
      I failed to wrap my head around the current logic. This commit rewrites
      the concurrency handling and simplifies it considerably, following
      similar patterns as in the rest of gnome-software.
      
      Not sure if this fixes the multitude of crashes reported against the
      search provider, but it should definitely make it easier for me to debug
      them in the future.
      27588054
    • Kalev Lember's avatar
      plugin loader: Return immediately from search when cancelled · da1f2757
      Kalev Lember authored
      Set the search task's return-on-cancel flag to make it immediately
      invoke the async callback when the cancellable gets cancelled.
      
      This makes it possible to simplify the calling code.
      da1f2757