GitLab

The goal is to be free of unused X class of problems. For this, CI and any "serious" builds will fail on warnings. Debug builds, used in development, will warn by default but not fail.

In addition, the 'strict' build option is added for when the debug build should fail on unused warnings as well.

A bunch of cleanups

See merge request !371

Add Ukrainian keyboard layout

Closes #223

See merge request !372

Fixes #223

Signed-off-by: Nazarii Kretovych <nazarii.kretovych@gmail.com>

This makes sure 'self' comes first. While at that fix the
function signatures and use ServerContextService directly
and add type checks so it's easy to notice when we messed up.

It's confusing when the object a method acts on is sometimes called
context and sometimes called state. So name it 'self' as we do
in other projects.

There's no point having it for a final type and it only
makes the code harder to read.

The previous commits show it's not really a derivable type
so make it a finale one.

It's unused

G_DECLARE_FINAL_TYPE does this for us

No changes needed.

No changes needed.

No changes needed

This fixes

../eek/eek-keyboard.c:71:5: warning: ignoring return value of ‘getrandom’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   71 |     getrandom(r, 6, GRND_NONBLOCK);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[17/32] Compiling C object 'src/25a6634@@libsqueekboard@sta/.._eek_eek-renderer.c.o'

This makes sure we don't have more warnings creeping in

This fixes

warning: unnecessary parentheses around block return value
   --> /var/scratch/librem5/squeekboard/src/layout.rs:110:13
    |
110 | /             (point.x > self.x && point.x < self.x + self.width
111 | |                 && point.y > self.y && point.y < self.y + self.height)
    | |______________________________________________________________________^
    |
    = note: `#[warn(unused_parens)]` on by default

warning: unused variable: `name`
   --> /var/scratch/librem5/squeekboard/src/keyboard.rs:195:10
    |
195 |     for (name, state) in keystates.iter() {
    |          ^^^^ help: consider prefixing with an underscore: `_name`

This fixes the

../eekboard/eekboard-context-service.c:244:13: warning: Deprecated pre-processor symbol, replace with
  244 |     self->priv = EEKBOARD_CONTEXT_SERVICE_GET_PRIVATE(self);

warning and makes us use more modern GObject style

This also fixes a leak of GSettingsSchema.

virtual_keyboard: Fix desynced modifiers state

See merge request !362

Document changes and release 1.9.3

Closes #212

See merge request !369

Terminal layout: another approach

See merge request !368

Brazilian Portuguese Keyboard Layout.

See merge request !365

This reverts commit 0c8feb76, reversing
changes made to 762e1243.

italian: Fix space and period

See merge request !364

size: Hardcode size to work around screen rotation

See merge request !361

This ensures that keymap switches leave modifiers and virtual keys in a known state.

New terminal layout, showing more useful keys at the same time

See merge request !345