• Andre Przywara's avatar
    SPL: FIT: refactor FDT loading · 4b9340ab
    Andre Przywara authored
    Currently the SPL FIT loader uses the spl_fit_select_fdt() function to
    find the offset to the right DTB within the FIT image.
    For this it iterates over all subnodes of the /configuration node in
    the FIT tree and compares all "description" strings therein using a
    board specific matching function.
    If that finds a match, it uses the string in the "fdt" property of that
    subnode to locate the matching subnode in the /images node, which points
    to the DTB data.
    Now this works very well, but is quite specific to cover this particular
    use case. To open up the door for a more generic usage, let's split this
    function into:
    1) a function that just returns the node offset for the matching
       configuration node (spl_fit_find_config_node())
    2) a function that returns the image data any given property in a given
       configuration node points to, additionally using a given index into
       a possbile list of strings (spl_fit_select_index())
    This allows us to replace the specific function above by asking for the
    image the _first string of the "fdt" property_ in the matching
    configuration subnode points to.
    This patch introduces no functional changes, it just refactors the code
    to allow reusing it later.
    (diff is overly clever here and produces a hard-to-read patch, so I
    recommend to throw a look at the result instead).
    Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
    Reviewed-by: default avatarLokesh Vutla <lokeshvuta@ti.com>
    Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
    Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
    Reviewed-by: default avatarKever Yang <kever.yang@rock-chips.com>
    Tested-by: default avatarKever Yang <kever.yang@rock-chips.com>
    Tested-by: default avatarJagan Teki <jagan@openedev.com>
spl_fit.c 7.84 KB