Commit 28b3594e authored by Doug Anderson's avatar Doug Anderson Committed by Simon Glass
Browse files

patman: Make "Reviewed-by" an important tag

Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag
used by upstream.  Stripping it is undesirable.  In fact, we should
treat it as important.
Signed-off-by: default avatarDoug Anderson <>
Reviewed-by: default avatarOtavio Salvador <>
Acked-by: default avatarSimon Glass <>
parent 5f6a1c42
......@@ -198,8 +198,9 @@ END
override the default signoff that patman automatically adds.
Tested-by: Their Name <email>
Reviewed-by: Their Name <email>
Acked-by: Their Name <email>
These indicate that someone has acked or tested your patch.
These indicate that someone has tested/reviewed/acked your patch.
When you get this reply on the mailing list, you can add this
tag to the relevant commit and the script will include it when
you send out the next version. If 'Tested-by:' is set to
......@@ -231,7 +232,6 @@ TEST=...
Review URL:
Exercise for the reader: Try adding some tags to one of your current
......@@ -31,7 +31,7 @@ from series import Series
# Tags that we detect and remove
re_remove = re.compile('^BUG=|^TEST=|^BRANCH=|^Change-Id:|^Review URL:'
# Lines which are allowed after a TEST= line
re_allowed_after_test = re.compile('^Signed-off-by:')
......@@ -46,7 +46,7 @@ re_cover = re.compile('^Cover-letter:')
re_series = re.compile('^Series-(\w*): *(.*)')
# Commit tags that we want to collect and keep
re_tag = re.compile('^(Tested-by|Acked-by|Cc): (.*)')
re_tag = re.compile('^(Tested-by|Acked-by|Reviewed-by|Cc): (.*)')
# The start of a new commit in the git log
re_commit = re.compile('^commit (.*)')
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment