Commit 29a1bedb authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Simon Glass
Browse files

dm: do not check the existence of uclass operation

The function uclass_add() checks uc_drv->ops as follows:

        if (uc_drv->ops) {
                dm_warn("No ops for uclass id %d\n", id);
                return -EINVAL;

It seems odd because it warns "No ops" when uc_drv->ops has
non-NULL pointer.  (Looks opposite.)

Anyway, most of UCLASS_DRIVER entries have no .ops member.
This check makes no sense.
Signed-off-by: default avatarMasahiro Yamada <>
Acked-by: default avatarSimon Glass <>
parent 81b4e751
......@@ -60,10 +60,6 @@ static int uclass_add(enum uclass_id id, struct uclass **ucp)
return -ENOENT;
if (uc_drv->ops) {
dm_warn("No ops for uclass id %d\n", id);
return -EINVAL;
uc = calloc(1, sizeof(*uc));
if (!uc)
return -ENOMEM;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment