Commit 4cc9699b authored by Tom Rini's avatar Tom Rini

common: env_nand: Ensure that we have nand_info[0] prior to use

Now that nand_info[] is an array of pointers we need to ensure that it's
been populated prior to use.  We may for example have ENV in NAND set in
configurations that run on boards with and without NAND (where default
env is fine enough, such as omap3_beagle and beagleboard (NAND) vs
beagle xM (no NAND)).

Fixes: b616d9b0 ("nand: Embed mtd_info in struct nand_chip")
Cc: Scott Wood <>
Signed-off-by: default avatarTom Rini <>
Acked-by: default avatarScott Wood <>
parent 183923d3
......@@ -163,6 +163,9 @@ static int erase_and_write_env(const struct env_location *location,
int ret = 0;
if (!nand_info[0])
return 1;
printf("Erasing %s...\n", location->name);
if (nand_erase_opts(nand_info[0], &location->erase_opts))
return 1;
......@@ -247,10 +250,10 @@ static int readenv(size_t offset, u_char *buf)
size_t blocksize, len;
u_char *char_ptr;
blocksize = nand_info[0]->erasesize;
if (!blocksize)
if (!nand_info[0])
return 1;
blocksize = nand_info[0]->erasesize;
len = min(blocksize, (size_t)CONFIG_ENV_SIZE);
while (amount_loaded < CONFIG_ENV_SIZE && offset < end) {
......@@ -387,12 +390,12 @@ void env_relocate_spec(void)
ret = get_nand_env_oob(nand_info[0], &nand_env_oob_offset);
* If unable to read environment offset from NAND OOB then fall through
* to the normal environment reading code below
if (!ret) {
if (nand_info[0] && !get_nand_env_oob(nand_info[0],
&nand_env_oob_offset)) {
printf("Found Environment offset in OOB..\n");
} else {
set_default_env("!no env offset in OOB");
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment