Commit 551288bd authored by John Keeping's avatar John Keeping Committed by Heiko Schocher
Browse files

rockchip: i2c: move register write out of inner loop

There is no point in writing intermediate values to the txdata

Also add padding to the debug logging to make it easier to read when
there are leading zeroes.
Signed-off-by: default avatarJohn Keeping <>
Acked-by: default avatarSimon Glass <>
parent 80333fd8
......@@ -277,9 +277,9 @@ static int rk_i2c_write(struct rk_i2c *i2c, uchar chip, uint reg, uint r_len,
} else {
txdata |= (*pbuf++)<<(j * 8);
writel(txdata, &regs->txdata[i]);
debug("I2c Write TXDATA[%d] = 0x%x\n", i, txdata);
writel(txdata, &regs->txdata[i]);
debug("I2c Write TXDATA[%d] = 0x%08x\n", i, txdata);
writel(I2C_CON_EN | I2C_CON_MOD(I2C_MODE_TX), &regs->con);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment