Commit 57a87a25 authored by Tom Rini's avatar Tom Rini
Browse files

usb gadget ether: Fix warning in is_eth_addr_valid()

The gadget ethernet driver needs to keep copies of the MAC address (at
both endpoints) as strings so it needs a custom function for validation
of the MAC.  It was not however performing a totally correct check and
also was emitting a warning about a set but unused variable.  The
solution to both is that after checking the string contents we use the
standard test for a valid MAC.

Cc: Joe Hershberger <>
Cc: Marek Vasut <>
Signed-off-by: default avatarTom Rini <>
Acked-by: default avatarJoe Hershberger <>
parent ac63f2a2
......@@ -1978,8 +1978,8 @@ static int is_eth_addr_valid(char *str)
p = q;
if (i == 6) /* it looks ok */
return 1;
/* Now check the contents. */
return is_valid_ether_addr(ea);
return 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment