Commit 5877de91 authored by Stephen Warren's avatar Stephen Warren Committed by Marek Vasut
Browse files

usb: dwc2: retry NAK'd interrupt transfers

IIUC, interrupt transfers are NAK'd by devices until they wish to trigger
an interrupt, and e.g. EHCI controllers retry these in HW until they are
ACK'd. However, DWC2 doesn't seem to retry, so we need to do this in SW.
In practice, I've seen DWC2_HCINT_FRMOVRUN happen too. I'm not quite sure
what this error implies; perhaps it's related to how near the end of a
USB frame we're at when the interrupt transfer is initiated? Anyway,
retrying this temporary error seems to be necessary too.

With all these commits applied, both my USB keyboards (one LS Lenovo and
one FS Dell) work correctly when there is no USB hub between the SoC and
the keyboard; We still need split transactions to be implemented for hubs
to work.
Signed-off-by: default avatarStephen Warren <>
parent e236519b
......@@ -723,6 +723,8 @@ int wait_for_chhltd(uint32_t *sub, int *toggle, bool ignore_ack)
return ret;
hcint = readl(&hc_regs->hcint);
return -EAGAIN;
if (ignore_ack)
hcint &= ~DWC2_HCINT_ACK;
......@@ -758,7 +760,7 @@ int chunk_msg(struct usb_device *dev, unsigned long pipe, int *pid, int in,
int max = usb_maxpacket(dev, pipe);
int eptype = dwc2_eptype[usb_pipetype(pipe)];
int done = 0;
int ret;
int ret = 0;
uint32_t sub;
uint32_t xfer_len;
uint32_t num_packets;
......@@ -813,10 +815,8 @@ int chunk_msg(struct usb_device *dev, unsigned long pipe, int *pid, int in,
ret = wait_for_chhltd(&sub, pid, ignore_ack);
if (ret) {
stop_transfer = 1;
if (ret)
if (in) {
xfer_len -= sub;
......@@ -835,7 +835,7 @@ int chunk_msg(struct usb_device *dev, unsigned long pipe, int *pid, int in,
dev->status = 0;
dev->act_len = done;
return 0;
return ret;
/* U-Boot USB transmission interface */
......@@ -904,8 +904,21 @@ int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
int len, int interval)
unsigned long timeout;
int ret;
/* FIXME: what is interval? */
return submit_bulk_msg(dev, pipe, buffer, len);
timeout = get_timer(0) + USB_TIMEOUT_MS(pipe);
for (;;) {
if (get_timer(0) > timeout) {
printf("Timeout poll on interrupt endpoint\n");
return -ETIMEDOUT;
ret = submit_bulk_msg(dev, pipe, buffer, len);
if (ret != -EAGAIN)
return ret;
/* U-Boot USB control interface */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment