Commit 8bb2bddc authored by Stephen Warren's avatar Stephen Warren Committed by Simon Glass
Browse files

buildman: don't fail --list-toolchains when toolchains fail

When a toolchain invocation fails, an exception is thrown but not caught
which then aborts the entire toolchain detection process. To solve this,
request that exceptions not be thrown, since the toolchain init code
already error-checks the command result. This solves e.g.:

         - found '/usr/bin/winegcc'
Traceback (most recent call last):
Exception: Error running '/usr/bin/winegcc --version'

Change-Id: I579c72ab3b021e38b14132893c3375ea257c74f0
Signed-off-by: default avatarStephen Warren <>
Acked-by: default avatarSimon Glass <>
Signed-off-by: default avatarSimon Glass <>
(formatted to 80cols)
parent 99b4eaa6
......@@ -39,7 +39,8 @@ class Toolchain:
# As a basic sanity check, run the C compiler with --version
cmd = [fname, '--version']
if test:
result = command.RunPipe([cmd], capture=True, env=env)
result = command.RunPipe([cmd], capture=True, env=env,
self.ok = result.return_code == 0
if verbose:
print 'Tool chain test: ',
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment