Commit e15bb3e6 authored by Simon Glass's avatar Simon Glass
Browse files

power: pmic: Use trailing_strtol() instead of a local function

Use the common function to obtain the number from the end of the string,
instead of a local function. Also tweak the position of a debug() statement.
Signed-off-by: default avatarSimon Glass <>
Tested-by: default avatarPrzemyslaw Marczak <>
Acked-by: default avatarPrzemyslaw Marczak <>
parent f26c8a8e
......@@ -9,6 +9,7 @@
#include <fdtdec.h>
#include <errno.h>
#include <dm.h>
#include <vsprintf.h>
#include <dm/lists.h>
#include <dm/device-internal.h>
#include <dm/uclass-internal.h>
......@@ -17,16 +18,6 @@
static ulong str_get_num(const char *ptr, const char *maxptr)
if (!ptr || !maxptr)
return 0;
while (!isdigit(*ptr) && ptr++ < maxptr);
return simple_strtoul(ptr, NULL, 0);
int pmic_bind_children(struct udevice *pmic, int offset,
const struct pmic_child_info *child_info)
......@@ -35,7 +26,6 @@ int pmic_bind_children(struct udevice *pmic, int offset,
struct driver *drv;
struct udevice *child;
const char *node_name;
int node_name_len;
int bind_count = 0;
int node;
int prefix_len;
......@@ -47,19 +37,19 @@ int pmic_bind_children(struct udevice *pmic, int offset,
for (node = fdt_first_subnode(blob, offset);
node > 0;
node = fdt_next_subnode(blob, node)) {
node_name = fdt_get_name(blob, node, &node_name_len);
node_name = fdt_get_name(blob, node, NULL);
debug("* Found child node: '%s' at offset:%d\n", node_name,
child = NULL;
for (info = child_info; info->prefix && info->driver; info++) {
debug(" - compatible prefix: '%s'\n", info->prefix);
prefix_len = strlen(info->prefix);
if (strncmp(info->prefix, node_name, prefix_len))
debug(" - compatible prefix: '%s'\n", info->prefix);
drv = lists_driver_lookup_name(info->driver);
if (!drv) {
debug(" - driver: '%s' not found!\n",
......@@ -78,10 +68,7 @@ int pmic_bind_children(struct udevice *pmic, int offset,
debug(" - bound child device: '%s'\n", child->name);
child->driver_data = str_get_num(node_name +
node_name +
child->driver_data = trailing_strtol(node_name);
debug(" - set 'child->driver_data': %lu\n",
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment