1. 04 Nov, 2012 13 commits
    • Kim Phillips's avatar
      common/cmd_*.c: sparse fixes · 088f1b19
      Kim Phillips authored
      
      
      cmd_boot.c:40:5: warning: symbol 'do_go' was not declared. Should it be static?
      cmd_bootm.c:164:6: warning: symbol '__arch_preboot_os' was not declared. Should it be static?
      cmd_bootm.c:477:5: warning: symbol 'do_bootm_subcommand' was not declared. Should it be static?
      cmd_bootm.c:1022:1: error: directive in argument list
      cmd_bootm.c:1028:1: error: directive in argument list
      cmd_bootm.c:1029:1: error: directive in argument list
      cmd_bootm.c:1036:1: error: directive in argument list
      cmd_bootm.c:1042:1: error: directive in argument list
      cmd_bootm.c:1044:1: error: directive in argument list
      cmd_bootm.c:1045:1: error: directive in argument list
      cmd_bootm.c:1047:1: error: directive in argument list
      cmd_bootm.c:1089:5: warning: symbol 'do_iminfo' was not declared. Should it be static?
      cmd_bootm.c:1176:5: warning: symbol 'do_imls' was not declared. Should it be static?
      cmd_bootm.c:1654:1: error: directive in argument list
      cmd_bootm.c:1660:1: error: directive in argument list
      cmd_console.c:32:5: warning: symbol 'do_coninfo' was not declared. Should it be s
      cmd_date.c:46:5: warning: symbol 'do_date' was not declared. Should it be static?
      cmd_echo.c:27:5: warning: symbol 'do_echo' was not declared. Should it be static?
      cmd_exit.c:27:5: warning: symbol 'do_exit' was not declared. Should it be static?
      cmd_fat.c:97:5: warning: symbol 'do_fat_ls' was not declared. Should it be static?
      cmd_fat.c:136:5: warning: symbol 'do_fat_fsinfo' was not declared. Should it be s
      cmd_fdt.c:66:5: warning: symbol 'do_fdt' was not declared. Should it be static?
      cmd_fdt.c:542:43: warning: incorrect type in assignment (different base types)
      cmd_fdt.c:542:43:    expected unsigned int [unsigned] [usertype] <noident>
      cmd_fdt.c:542:43:    got restricted __be32 [usertype] <noident>
      cmd_fdt.c:679:42: warning: cast to restricted __be32
      cmd_fdt.c:820:1: error: directive in argument list
      cmd_fdt.c:822:1: error: directive in argument list
      cmd_flash.c:292:5: warning: symbol 'do_flinfo' was not declared. Should it be static?
      cmd_flash.c:324:5: warning: symbol 'do_flerase' was not declared. Should it be static?
      cmd_flash.c:457:5: warning: symbol 'do_protect' was not declared. Should it be st
      cmd_help.c:27:5: warning: symbol 'do_help' was not declared. Should it be static?
      cmd_i2c.c:136:6: warning: symbol '__def_i2c_init_board' was not declared. Should it be static?
      cmd_i2c.c:144:14: warning: symbol '__def_i2c_get_bus_speed' was not declared. Should it be static?
      cmd_i2c.c:151:5: warning: symbol '__def_i2c_set_bus_speed' was not declared. Should it be static?
      cmd_i2c.c:1322:1: error: directive in argument list
      cmd_i2c.c:1324:1: error: directive in argument list
      cmd_i2c.c:1326:1: error: directive in argument list
      cmd_i2c.c:1328:1: error: directive in argument list
      cmd_i2c.c:1337:1: error: directive in argument list
      cmd_i2c.c:1339:1: error: directive in argument list
      cmd_irq.c:27:5: warning: symbol 'do_interrupts' was not declared. Should it be static?
      cmd_itest.c:133:5: warning: symbol 'binary_test' was not declared. Should it be static?
      cmd_itest.c:158:5: warning: symbol 'do_itest' was not declared. Should it be stat
      cmd_load.c:54:5: warning: symbol 'do_load_serial' was not declared. Should it be static?
      cmd_load.c:431:6: warning: symbol 'his_eol' was not declared. Should it be static?
      cmd_load.c:432:6: warning: symbol 'his_pad_count' was not declared. Should it be static?
      cmd_load.c:433:6: warning: symbol 'his_pad_char' was not declared. Should it be static?
      cmd_load.c:434:6: warning: symbol 'his_quote' was not declared. Should it be static?
      cmd_load.c:436:5: warning: symbol 'do_load_serial_bin' was not declared. Should it be static?
      cmd_load.c:549:6: warning: symbol 'send_pad' was not declared. Should it be static?
      cmd_load.c:558:6: warning: symbol 'ktrans' was not declared. Should it be static?
      cmd_load.c:568:5: warning: symbol 'chk1' was not declared. Should it be static?
      cmd_load.c:578:6: warning: symbol 's1_sendpacket' was not declared. Should it be static?
      cmd_load.c:587:6: warning: symbol 'send_ack' was not declared. Should it be static?
      cmd_load.c:600:6: warning: symbol 'send_nack' was not declared. Should it be static?
      cmd_load.c:614:6: warning: symbol 'os_data_init' was not declared. Should it be static?
      cmd_load.c:615:6: warning: symbol 'os_data_char' was not declared. Should it be static?
      cmd_load.c:657:6: warning: symbol 'k_data_init' was not declared. Should it be static?
      cmd_load.c:663:6: warning: symbol 'k_data_save' was not declared. Should it be static?
      cmd_load.c:669:6: warning: symbol 'k_data_restore' was not declared. Should it be static?
      cmd_load.c:675:6: warning: symbol 'k_data_char' was not declared. Should it be static?
      cmd_load.c:693:6: warning: symbol 'send_parms' was not declared. Should it be static?
      cmd_load.c:694:6: warning: symbol 'send_ptr' was not declared. Should it be static?
      cmd_load.c:698:6: warning: symbol 'handle_send_packet' was not declared. Should i
      cmd_mdio.c:60:5: warning: symbol 'mdio_write_ranges' was not declared. Should it be static?
      cmd_mdio.c:82:5: warning: symbol 'mdio_read_ranges' was not declared. Should it be static?
      cmd_mdio.c:115:5: warning: symbol 'extract_reg_range' was not declared. Should it be static?
      cmd_mdio.c:144:5: warning: symbol 'extract_phy_range' was not declared. Should it
      cmd_mem.c:54:5: warning: symbol 'do_mem_md' was not declared. Should it be static?
      cmd_mem.c:150:5: warning: symbol 'do_mem_mm' was not declared. Should it be static?
      cmd_mem.c:154:5: warning: symbol 'do_mem_nm' was not declared. Should it be static?
      cmd_mem.c:159:5: warning: symbol 'do_mem_mw' was not declared. Should it be static?
      cmd_mem.c:256:5: warning: symbol 'do_mem_cmp' was not declared. Should it be static?
      cmd_mem.c:326:5: warning: symbol 'do_mem_cp' was not declared. Should it be static?
      cmd_mem.c:436:5: warning: symbol 'do_mem_base' was not declared. Should it be static?
      cmd_mem.c:449:5: warning: symbol 'do_mem_loop' was not declared. Should it be static?
      cmd_mem.c:595:5: warning: symbol 'do_mem_mtest' was not declared. Should it be static?
      cmd_mem.c:618:26: warning: Using plain integer as NULL pointer
      cmd_mem.c:1057:5: warning: symbol 'do_mem_crc' was not declared. Should it be static?
      cmd_misc.c:30:5: warning: symbol 'do_sleep' was not declared. Should it be static
      cmd_mmc.c:118:5: warning: symbol 'do_mmcinfo' was not declared. Should it be static?
      cmd_mmc.c:272:32: warning: Using plain integer as NULL pointer
      cmd_mmc.c:150:5: warning: symbol 'do_mmcops' was not declared. Should it be stati
      cmd_mp.c:27:1: warning: symbol 'cpu_cmd' was not declared. Should it be static?
      cmd_mp.c:85:1: error: directive in argument list
      cmd_mp.c:88:1: error: directive in argument list
      cmd_mtdparts.c:150:18: warning: symbol 'mtdids' was not declared. Should it be static?
      cmd_mtdparts.c:153:18: warning: symbol 'devices' was not declared. Should it be static?
      cmd_mtdparts.c:713:5: warning: symbol 'mtd_device_validate' was not declared. Should it be static?
      cmd_mtdparts.c:1887:5: warning: symbol 'do_chpart' was not declared. Should it be static?
      cmd_mtdparts.c:1925:5: warning: symbol 'do_mtdparts' was not declared. Should it be static?
      cmd_mtdparts.c:2060:1: error: directive in argument list
      cmd_mtdparts.c:2063:1: error: directive in argument list
      cmd_mtdparts.c:2066:1: error: directive in argument list
      cmd_mtdparts.c:2071:1: error: directive in argument list
      cmd_mtdparts.c:2073:1: error: directive in argument list
      cmd_nand.c:377:18: error: bad constant expression
      cmd_nand.c:431:5: warning: symbol 'do_nand' was not declared. Should it be static?
      cmd_nand.c:796:1: error: directive in argument list
      cmd_nand.c:801:1: error: directive in argument list
      cmd_nand.c:802:1: error: directive in argument list
      cmd_nand.c:806:1: error: directive in argument list
      cmd_nand.c:819:1: error: directive in argument list
      cmd_nand.c:824:1: error: directive in argument list
      cmd_nand.c:825:1: error: directive in argument list
      cmd_nand.c:831:1: error: directive in argument list
      cmd_nand.c:918:5: warning: symbol 'do_nandboot' was not declared. Should it be static?
      cmd_net.c:33:5: warning: symbol 'do_bootp' was not declared. Should it be static?
      cmd_net.c:107:5: warning: symbol 'do_dhcp' was not declared. Should it be static?
      cmd_net.c:120:5: warning: symbol 'do_nfs' was not declared. Should it be static?
      cmd_nvedit.c:138:5: warning: symbol 'do_env_print' was not declared. Should it be static?
      cmd_nvedit.c:323:5: warning: symbol '_do_env_set' was not declared. Should it be static?
      cmd_nvedit.c:435:5: warning: symbol 'do_env_set' was not declared. Should it be static?
      cmd_nvedit.c:514:5: warning: symbol 'do_env_edit' was not declared. Should it be static?
      cmd_nvedit.c:620:5: warning: symbol 'do_env_save' was not declared. Should it be static?
      cmd_nvedit.c:1016:1: error: directive in argument list
      cmd_nvedit.c:1018:1: error: directive in argument list
      cmd_nvedit.c:1021:1: error: directive in argument list
      cmd_nvedit.c:1023:1: error: directive in argument list
      cmd_nvedit.c:1024:1: error: directive in argument list
      cmd_nvedit.c:1026:1: error: directive in argument list
      cmd_nvedit.c:1027:1: error: directive in argument list
      cmd_nvedit.c:1029:1: error: directive in argument list
      cmd_nvedit.c:1030:1: error: directive in argument list
      cmd_nvedit.c:1032:1: error: directive in argument list
      cmd_nvedit.c:1034:1: error: directive in argument list
      cmd_nvedit.c:1036:1: error: directive in argument list
      cmd_nvedit.c:1037:1: error: directive in argument list
      cmd_nvedit.c:1039:1: error: directive in argument list
      cmd_pci.c:38:17: warning: symbol 'ShortPCIListing' was not declared. Should it be static?
      cmd_pci.c:38:22: warning: 'ShortPCIListing' defined but not used [-Wunused-variable]
      cmd_pci.c:411:5: warning: symbol 'do_pci' was not declared. Should it be static?
      cmd_pci.c:494:1: error: directive in argument list
      cmd_pci.c:497:1: error: directive in argument list
      cmd_reginfo.c:40:5: warning: symbol 'do_reginfo' was not declared. Should it be static?
      cmd_sata.c:31:5: warning: symbol 'sata_curr_device' was not declared. Should it be static?
       note -> ata_piix.c doesn't seem to use 'sata_curr_device'; deleted.
      cmd_sata.c:32:18: warning: symbol 'sata_dev_desc' was not declared. Should it be static?
      cmd_sata.c:70:5: warning: symbol 'do_sata' was not declared. Should it be static?
      cmd_setexpr.c:53:5: warning: symbol 'do_setexpr' was not declared. Should it be static?
      cmd_source.c:186:1: error: directive in argument list
      cmd_source.c:190:1: error: directive in argument list
      cmd_test.c:27:5: warning: symbol 'do_test' was not declared. Should it be static?
      cmd_test.c:153:5: warning: symbol 'do_false' was not declared. Should it be static?
      cmd_test.c:164:5: warning: symbol 'do_true' was not declared. Should it be static
      cmd_usb.c:43:6: warning: symbol 'usb_get_class_desc' was not declared. Should it be static?
      cmd_usb.c:69:6: warning: symbol 'usb_display_class_sub' was not declared. Should it be static?
      cmd_usb.c:151:6: warning: symbol 'usb_display_string' was not declared. Should it be static?
      cmd_usb.c:161:6: warning: symbol 'usb_display_desc' was not declared. Should it be static?
      cmd_usb.c:195:6: warning: symbol 'usb_display_conf_desc' was not declared. Should it be static?
      cmd_usb.c:210:6: warning: symbol 'usb_display_if_desc' was not declared. Should it be static?
      cmd_usb.c:227:6: warning: symbol 'usb_display_ep_desc' was not declared. Should it be static?
      cmd_usb.c:252:6: warning: symbol 'usb_display_config' was not declared. Should it be static?
      cmd_usb.c:283:6: warning: symbol 'usb_show_tree_graph' was not declared. Should it be static?
      cmd_usb.c:343:6: warning: symbol 'usb_show_tree' was not declared. Should it be static?
      cmd_usb.c:356:5: warning: symbol 'do_usbboot' was not declared. Should it be static?
      cmd_usb.c:366:5: warning: symbol 'do_usb' was not declared. Should it be static?
      cmd_version.c:31:5: warning: symbol 'do_version' was not declared. Should it be s
      cmd_ximg.c:46:1: warning: symbol 'do_imgextract' was not declared. Should it be static?
      cmd_ximg.c:272:1: error: directive in argument list
      cmd_ximg.c:276:1: error: directive in argument list
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      088f1b19
    • Kim Phillips's avatar
      include/image.h: sparse fixes · 2f220500
      Kim Phillips authored
      
      
      include/image.h:378:1: warning: cast to restricted __be32
      include/image.h:381:1: warning: cast to restricted __be32
      include/image.h:382:1: warning: cast to restricted __be32
      include/image.h:383:1: warning: cast to restricted __be32
      
      fix by annotating image header integers big endian.
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      2f220500
    • Kim Phillips's avatar
      arch/powerpc/lib/board.c, *traps.c: sparse fixes · 20051f2a
      Kim Phillips authored
      
      
      traps.c:*:1: warning: symbol 'print_backtrace' was not declared. Should it be static?
      traps.c:93:1: warning: symbol '_exception' was not declared. Should it be static?
      board.c:166:6: warning: symbol '__board_add_ram_info' was not declared. Should it be static?
      board.c:174:5: warning: symbol '__board_flash_wp_on' was not declared. Should it be static?
      board.c:187:6: warning: symbol '__cpu_secondary_init_r' was not declared. Should it be static?
      board.c:265:12: warning: symbol 'init_sequence' was not declared. Should it be static?
      board.c:348:5: warning: symbol '__fixup_cpu' was not declared. Should it be static?
      board.c:405:53: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      20051f2a
    • Kim Phillips's avatar
      arch/powerpc/lib/extable.c: sparse fix · fe44f452
      Kim Phillips authored
      
      
      extable.c:66:9: warning: symbol 'ex_tab_message' was not declared. Should it be static?
      
      making it static can produce a new build warning on some boards:
      
      extable.c:66:12: warning: 'ex_tab_message' defined but not used [-Wunused-variable]
      
      but ex_tab_message doesn't do much even when used, so just remove it.
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      fe44f452
    • Kim Phillips's avatar
      arch/powerpc/include/asm/io.h: fix warning: preprocessor token __iomem redefined · cdfdb8d7
      Kim Phillips authored
      a fixup __iomem definition in arch code appears to be placed there as a cover
      up from a code import from linux when u-boot didn't yet have a compiler.h,
      introduced by commit 812711ce "Implement
      __raw_{read,write}[bwl] on all architectures".
      
      git show 812711ce:include/linux/compiler.h
      fatal: Path 'include/linux/compiler.h' exists on disk, but not in '812711ce
      
      '.
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      cdfdb8d7
    • Kim Phillips's avatar
      include/linux/stddef.h: avoid 'warning: preprocessor token offsetof redefined' · aa9e891c
      Kim Phillips authored
      
      
      hack to avoid:
      
      /opt/gcc-4.6.3-nolibc/powerpc-linux/bin/../lib/gcc/powerpc-linux/4.6.3/include/stddef.h:413:9: warning: preprocessor token offsetof redefined
      u-boot/include/linux/stddef.h:20:9: this was the original definition
      
      tried protecting with __KERNEL__, and #including compiler.h first.
      
      Even tried include dir reordering to no avail:
      
       +++ b/config.mk
       @@ -194,7 +194,11 @@ OBJCFLAGS += --gap-fill=0xff
       gccincdir := $(shell $(CC) -print-file-name=include)
      
       CPPFLAGS := $(DBGFLAGS) $(OPTFLAGS) $(RELFLAGS)                \
       -       -D__KERNEL__
       +       -D__KERNEL__  \
       +       -I $(gccincdir) \
       +       -nostdinc
       +
       +#      -isystem $(gccincdir) \
      
       # Enable garbage collection of un-used sections for SPL
       ifeq ($(CONFIG_SPL_BUILD),y)
       @@ -227,8 +231,7 @@ CPPFLAGS += -I$(OBJTREE)/include2 -I$(OBJTREE)/include
       endif
      
       CPPFLAGS += -I$(TOPDIR)/include
       -CPPFLAGS += -fno-builtin -ffreestanding -nostdinc      \
       -       -isystem $(gccincdir) -pipe $(PLATFORM_CPPFLAGS)
       +CPPFLAGS += -fno-builtin -ffreestanding -pipe $(PLATFORM_CPPFLAGS)
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      aa9e891c
    • Kim Phillips's avatar
      include/linux/unaligned/generic.h: fix warning: preprocessor token __force redefined · 25b26ec6
      Kim Phillips authored
      include/linux/unaligned/generic.h:5:9: warning: preprocessor token __force redefined
      include/linux/compiler.h:10:10: this was the original definition
      
      fixup __force definitions in compat.h code appears to be placed
      there as a cover up from a code import from linux when u-boot didn't yet
      have a compiler.h, introduced by commit
      b1b4e89a
      
       "Add LZO decompressor support".
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      25b26ec6
    • Kim Phillips's avatar
      include/linux/compat.h: fix warning: preprocessor token {__iomem, __user} redefined · 0d4c1c91
      Kim Phillips authored
      include/linux/compat.h:4:9: warning: preprocessor token __user redefined
      include/linux/compiler.h:7:10: this was the original definition
      include/linux/compat.h:5:9: warning: preprocessor token __iomem redefined
      include/linux/compiler.h:12:10: this was the original definition
      
      fixup __iomem, __user definitions in compat.h code appears to be placed
      there as a cover up from a code import from linux when u-boot didn't yet
      have a compiler.h, introduced by commit
      932394ac
      
       "Rewrite of NAND code based on
      what is in 2.6.12 Linux kernel".
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      0d4c1c91
    • Kim Phillips's avatar
      include/linux/byteorder: import latest endian definitions from linux · eef1cf2d
      Kim Phillips authored
      
      
      u-boot's byteorder headers did not contain endianness attributions
      for use with sparse, causing a lot of false positives.  Import the
      kernel's latest definitions, and enable them by including compiler.h
      and types.h.  They come with 'const' added for some swab functions, so
      fix those up, too:
      
      include/linux/byteorder/big_endian.h:46:2: warning: passing argument 1 of '__swab64p' discards 'const' qualifier from pointer target type [enabled by default]
      
      Also, note: u-boot's historic __BYTE_ORDER definition has been
      preserved (for the time being at least).
      
      We also remove ad-hoc barrier() definitions, since we're including
      compiler.h in files that hadn't in the past:
      
      macb.c:54:0: warning: "barrier" redefined [enabled by default]
      
      In addition, including compiler.h in byteorder changes the 'noinline'
      definition to expand to __attribute__((noinline)).  This fixes
      arch/powerpc/lib/bootm.c:
      
      bootm.c:329:16: error: attribute '__attribute__': unknown attribute
      bootm.c:329:16: error: expected ')' before '__attribute__'
      bootm.c:329:25: error: expected identifier or '(' before ')' token
      
      powerpc sparse builds yield:
      
      include/common.h:356:22: error: marked inline, but without a definition
      
      the unknown-reason inlining without a definition is considered obsolete
      given it was part of the 2002 initial commit, and no arm version was
      'fixed.'
      
      also fixed:
      ydirectenv.h:60:0: warning: "inline" redefined [enabled by default]
      
      and:
      
      Configuring for devconcenter - Board: intip, Options: DEVCONCENTER
      make[1]: *** [4xx_ibm_ddr2_autocalib.o] Error 1
      make: *** [arch/powerpc/cpu/ppc4xx/libppc4xx.o] Error 2
      powerpc-fsl-linux-size: './u-boot': No such file
      4xx_ibm_ddr2_autocalib.c: In function 'DQS_autocalibration':
      include/asm/ppc4xx-sdram.h:1407:13: sorry, unimplemented: inlining failed in call to 'ppc4xx_ibm_ddr2_register_dump': function body not available
      4xx_ibm_ddr2_autocalib.c:1243:32: sorry, unimplemented: called from here
      
      and:
      
      In file included from crc32.c:50:0:
      crc32table.h:4:1: warning: implicit declaration of function '___constant_swab32' [-Wimplicit-function-declaration]
      crc32table.h:4:1: error: initializer element is not constant
      crc32table.h:4:1: error: (near initialization for 'crc32table_le[0]')
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      [trini: Remove '#endif' in include/common.h around setenv portion]
      Signed-off-by: default avatarTom Rini <trini@ti.com>
      eef1cf2d
    • Stephen Warren's avatar
      fs: rename fsload command to load · f9b55e22
      Stephen Warren authored
      
      
      When the generic filesystem load command "fsload" was written, I felt
      that "load" was too generic of a name for it, since many other similar
      commands already existed. However, it turns out that there is already
      an "fsload" command, so that name cannot be used. Rename the new
      "fsload" to plain "load" to avoid the conflict. At least anyone who's
      used a Basic interpreter should feel familiar with the name!
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      f9b55e22
    • Stephen Warren's avatar
      fs: fix number base behaviour change in fatload/ext*load · 3f83c87e
      Stephen Warren authored
      Commit 045fa1e1
      
       "fs: add filesystem switch libary, implement ls and
      fsload commands" unified the implementation of fatload and ext*load
      with the new command fsload. However, this altered the interpretation
      of command-line numbers from always being base-16, to requiring a "0x"
      prefix for base-16 numbers. Enhance do_fsload() to allow commands to
      specify which base to use.
      
      Use base 0, thus requiring a "0x" prefix for the new fsload command.
      This feels much cleaner than assuming base 16.
      
      Use base 16 for the pre-existing fatload and ext*load to prevent a
      change in behaviour.
      
      Use base 16 exclusively for the loadaddr environment variable, since
      that variable is interpreted in multiple places, so we don't want the
      behaviour to change.
      
      Update command help text to make it clear where numbers are assumed to
      be hex, and where an explicit "0x" prefix is required.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Reviewed-by: default avatarBenoît Thébaudeau <benoit.thebaudeau@advansee.com>
      3f83c87e
    • Stephen Warren's avatar
      cmd_ext4: remove TABs from command help text · b6a30444
      Stephen Warren authored
      
      
      TABs in the help text won't line up in the same place on the console as
      in a source editor. Replace them with spaces to make ensuring correct
      alignment easier.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Reviewed-by: default avatarBenoît Thébaudeau <benoit.thebaudeau@advansee.com>
      b6a30444
    • Stephen Warren's avatar
      fs: fix do_fsload() handling of optional arguments · e9b0f99e
      Stephen Warren authored
      
      
      Most arguments to the shell command do_fsload() implements are optional.
      Fix the minimum argc check to respect that. Cater for the situation
      where argv[2] is not provided.
      
      Enhance both do_fsload() and do_ls() to check the maximum number of
      arguments too. While this check would typically be implemented via
      U_BOOT_CMD()'s max_args parameter, if these functions are called
      directly, then that check won't exist.
      
      Finally, alter do_ls() to check (argc >= 4) rather than (argc == 4) so
      that if the function is enhanced to allow extra arguments in the future,
      this test won't need to be changed at that time.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Reviewed-by: default avatarBenoît Thébaudeau <benoit.thebaudeau@advansee.com>
      e9b0f99e
  2. 02 Nov, 2012 27 commits