1. 09 Aug, 2014 28 commits
    • Stephen Warren's avatar
      net: BOOTP retry timeout improvements · f59be6e8
      Stephen Warren authored
      Currently, the BOOTP code sends out its initial request as soon as the
      Ethernet driver indicates "link up". If this packet is lost or not
      replied to for some reason, the code waits for a 1s timeout before
      retrying. For some reason, such early packets are often lost on my
      system, so this causes an annoying delay.
      To optimize this, modify the BOOTP code to have very short timeouts for
      the first packet transmitted, but gradually increase the timeout each
      time a timeout occurs. This way, if the first packet is lost, the second
      packet is transmitted quite quickly and hence the overall delay is low.
      However, if there's still no response, we don't keep spewing out packets
      at an insane speed.
      It's arguably more correct to try and find out why the first packet is
      lost. However, it seems to disappear inside my Ethenet chip; the TX chip
      indicates no error during TX (not that it has much in the way of
      reporting...), yet wireshark on the RX side doesn't see any packet.
      FWIW, I'm using an ASIX USB Ethernet adapter. Perhaps "link up" is
      reported too early or based on the wrong condition in HW, and we should
      add some fixed extra delay into the driver. However, this would slow down
      every link up event even if it ends up not being needed in some cases.
      Having BOOTP retry quickly applies the fix/WAR to every possible
      Ethernet device, and is quite simple to implement, so seems a better
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Acked-by: default avatarJoe Hershberger <joe.hershberger@ni.com>
    • maxin.john@enea.com's avatar
      emif.h: remove duplicated argument to | · 194c1ed4
      maxin.john@enea.com authored
      Remove the duplicated argument to | in two places. Reported
      by Coccinelle (http://coccinelle.lip6.fr/).
      Signed-off-by: default avatarMaxin B. John <maxin.john@enea.com>
    • maxin.john@enea.com's avatar
      vitesse: remove duplicated argument to || · 79e86ccb
      maxin.john@enea.com authored
      Remove the duplicated argument to || check
      Signed-off-by: default avatarMaxin B. John <maxin.john@enea.com>
    • Ian Campbell's avatar
      board_r: Add missing return to initr_doc · 19ad527d
      Ian Campbell authored
      I happened to spot this while working in the area.
      Signed-off-by: default avatarIan Campbell <ijc@hellion.org.uk>
      Acked-by: default avatarSimon Glass <sjg@chromium.org>
      Cc: Simon Glass <sjg@chromium.org>
    • Chris Packham's avatar
      Makefile: use u-boot.map for binary_size_check · 3ce7a4fe
      Chris Packham authored
      u-boot.map is generated automatically by the compiler and more
      importantly can handle addresses >4GB.
    • Chris Packham's avatar
      Makefile: use $(shell ...) for determining file_size · 67b060b4
      Chris Packham authored
      file_size was being calculated using back-ticks but map_size uses
      $(shell ...). Update the file_size calculation to use $(shell ...).
      From: Jeroen Hofstee <jeroen@myspectrum.nl>
      The binary_size_check target relies on stat -c %s
      to return the size of u-boot.bin. This only works
      with GNU stat though. Use wc instead.
      Signed-off-by: default avatarChris Packham <judge.packham@gmail.com>
      Acked-by: default avatarSimon Glass <sjg@chromium.org>
    • Stephen Warren's avatar
      pxe: clear Bootfile before returning · ded2e20e
      Stephen Warren authored
      When "pxe boot" downloads the initrd/kernel/DTB, netboot_common() saves
      the downloaded filename to global variable BootFile. If the boot
      operation is aborted, this global state is not cleared. If "dhcp" is
      executed later without any arguments, BootFile is not cleared, and when
      the DHCP response is received, BootpCopyNetParams() writes the value into
      environment variable bootfile.
      This causes the following scenario:
      * Boot script executes dhcp; pxe get; pxe boot
      * User CTRL-C's the PXE menu, which causes the first menu item to be
        booted, which causes some file to be downloaded.
        (This boot-on-CTRL-C behaviour is arguably a bug too, but it's a
        separate bug and the bug this patch fixes would still exist if the user
        simply waited to press CTRL-C until "pxe boot" started downloading
      * User CTRL-C's the file downloads, but the filename is still written to
        the bootfile environment variable.
      * User re-runs the boot command, which in my case executes "dhcp; pxe get;
        pxe boot" again, and "dhcp" picks up the saved bootfile environment
        variable and proceeds to download a file that it shouldn't.
      To solve this, modify the implementation of "pxe get" to clear BootFile
      if the whole boot operation fails, which avoids this whole mess.
      An alternative would be to modify netboot_common() such that the no-
      arguments case explicitly clears the global variable BootFile. However,
      that would prevent the following command sequences from working:
      $ dhcp filename # downloads "filename"
      $ dhcp          # downloads $bootfile, i.e. "filename"
      $ setenv bootfile filename
      $ dhcp          # downloads $bootfile, i.e. "filename"
      ... and I assume someone relies on U-Boot working that way.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Acked-by: default avatarJoe Hershberger <joe.hershberger@ni.com>
    • Barnes, Clifton A's avatar
      doc: README.android-fastboot: Add note about vendor ID · 183cbff7
      Barnes, Clifton A authored
      The Android fastboot client only communicates with specific vendor IDs.
      This addition to the documentation points out that fact so everyone is
      aware that not just any vendor ID will work and where to find the IDs
      that will.
      Signed-off-by: default avatarClifton Barnes <cabarnes@indesign-llc.com>
      Cc: Rob Herring <robh@kernel.org>
    • Łukasz Majewski's avatar
      ext4: trats: trats2: Modify dfu_alt_info's file names to have absolute path · dcb7eb66
      Łukasz Majewski authored
      After the clean up performed in the commit 1151b7ac10b81ecbb the DFU subsystem
      requires absolute patch for correct operation.
      Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
    • Michael van der Westhuizen's avatar
      Implement generalised RSA public exponents for verified boot · e0f2f155
      Michael van der Westhuizen authored
      Remove the verified boot limitation that only allows a single
      RSA public exponent of 65537 (F4).  This change allows use with
      existing PKI infrastructure and has been tested with HSM-based
      Change the configuration OF tree format to store the RSA public
      exponent as a 64 bit integer and implement backward compatibility
      for verified boot configuration trees without this extra field.
      Parameterise vboot_test.sh to test different public exponents.
      Mathematics and other hard work by Andrew Bott.
      Tested with the following public exponents: 3, 5, 17, 257, 39981,
      50457, 65537 and 4294967297.
      Signed-off-by: default avatarAndrew Bott <Andrew.Bott@ipaccess.com>
      Signed-off-by: default avatarAndrew Wishart <Andrew.Wishart@ipaccess.com>
      Signed-off-by: default avatarNeil Piercy <Neil.Piercy@ipaccess.com>
      Signed-off-by: default avatarMichael van der Westhuizen <michael@smart-africa.com>
      Cc: Simon Glass <sjg@chromium.org>
    • Nobuhiro Iwamatsu's avatar
      serial: sh: Add support External Clock mode · 53022c31
      Nobuhiro Iwamatsu authored
      R8A7780 and R7A7791 of rmobile supports External Clock mode, and these uses
      different from Internal Clock mode registers and calculations to the baud rate
      setting. This adds function for External Clock mode.
      Signed-off-by: default avatarNobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
      Signed-off-by: default avatarNobuhiro Iwamatsu <iwamatsu@nigauri.org>
    • Nobuhiro Iwamatsu's avatar
      serial: sh: Add support DL and CKS register for R8A7794 · 1a223c93
      Nobuhiro Iwamatsu authored
      R8A7794 has DL and CKS register, and these registers are used in external clock
      mode. This adds support these for R8A7794.
      Signed-off-by: default avatarNobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
      Signed-off-by: default avatarNobuhiro Iwamatsu <iwamatsu@nigauri.org>
    • Nobuhiro Iwamatsu's avatar
      usb: ehci: rmobile: Remove xHCI address · 5906fade
      Nobuhiro Iwamatsu authored
      echi-rmobile does not support xHCI. This removes xHCI address
      from address table. And this revise a value of CONFIG_USB_MAX_CONTROLLER_COUNT
      for lager board and koelsh board.
      Signed-off-by: default avatarNobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
    • Nobuhiro Iwamatsu's avatar
      usb: ehci: rmobile: Add support R8A7794 · ed7ce836
      Nobuhiro Iwamatsu authored
      R8A7794 has same IP of USB controller as R8A7790 and R8A7791.
      This addes support for R8A7794.
      Signed-off-by: default avatarNobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
    • Stephen Warren's avatar
      dfu: fix readback buffer overflow test · 67ab0a5e
      Stephen Warren authored
      The buffer is too small if it's < size to read, not if it's <= the size.
      This fixes the 1MB test case on Tegra, which has a 1MB buffer.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      test: dfu: add some more test cases · 54ce79c8
      Stephen Warren authored
      On Tegra, the DFU buffer size is 1M. Consequently, the 8M test always
      fails. Add tests for the 1M size, and one byte less as a corner case,
      so that some large tests are executed and expected to pass.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      test: dfu: cleanup before execution · c0e6663b
      Stephen Warren authored
      Call cleanup() before running tests too. If a previous test was CTRL-C'd
      some stale files may have been left around. dfu-util refuses to receive
      a file to a filename that already exists, which results in false test
      failures if the files aren't cleaned up first.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Lukasz Majewski's avatar
      thor: defer parsing of device string to IO backend · 90fadb57
      Lukasz Majewski authored
      Commit d4f5ef59cc7 "dfu: defer parsing of device string to IO backend" changed
      the function signature of dfu_init_env_entities(). Adjust cmd_thordown.c
      to match that change.
      Also, apply the same change as commit d6d37d737b58e "dfu: free entities
      when parsing fails" to cmd_thordown.c.
      Fixes: d4f5ef59cc7 ("dfu: defer parsing of device string to IO backend")
      Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
      Reviewed-by: default avatarStephen Warren <swarren@nvidia.com>
    • Lukasz Majewski's avatar
      test:dfu: README file update · 50a35321
      Lukasz Majewski authored
      Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
    • Stephen Warren's avatar
      test: dfu: script enhancements · 7ad67e55
      Stephen Warren authored
      Various misc enhancements to dfu_gadget_test.sh:
      * After every write (download), perform a write to a different file
        with different data. This ensures that the DFU buffer's content is
        replaced, so that if the read (upload) succeeds, we know that the
        correct data was actually read from the storage device, rather than
        simply being left over in the DFU buffer. This requires two alt
        setting names to be passed to the script, and a dummy data file to
        be generated by dfu_gadget_test_init.sh.
      * Fix the assumption that dfu_gadget_test.sh is run from the directory
        that contains it, by cd'ing to that directory before invoking
      * Use $DIR$RCV_DIR consistently, rather than using plain $RCV_DIR in
        some places.
      * Add 959, 961 test file sizes, to be consistent with having one
        more than and one less than all the other "round" sizes 64, 128, and
      * Remove references to $BKP_DIR from dfu_gadget_test_init.sh, since it
        isn't used.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Lukasz Majewski's avatar
      test:dfu: Add test scripts for testing DFU regression · a4c86bbb
      Lukasz Majewski authored
      This commit adds test scripts for testing if any commit has introduced
      regression to the DFU subsystem.
      It uses md5 to test if sent and received file is correct.
      The test detailed description is available at README file.
      Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
    • Stephen Warren's avatar
      dfu: add SF backend · 6f12ebf6
      Stephen Warren authored
      This allows SPI Flash to be programmed using DFU.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      dfu: add free_entity() to struct dfu_entity · cb7bd2e0
      Stephen Warren authored
      This allows the backend to free any resources allocated during the
      relevant dfu_fill_entity_*() call. This will soon be used by the
      SF backend.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      dfu: allow backend to specify a maximum buffer size · 7ac1b410
      Stephen Warren authored
      CONFIG_SYS_DFU_DATA_BUF_SIZE may be large to allow for FAT/ext layouts
      to transfer large files. However, this means that individual write
      operations will take a long time. Allow backends to specify a maximum
      buffer size, so that each write operation is limited to a smaller data
      block. This prevents the DFU protocol from timing out when e.g. writing
      to SPI flash. I would guess that NAND might benefit from setting this
      value too, but I can't test that.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      dfu: defer parsing of device string to IO backend · dd64827e
      Stephen Warren authored
      Devices are not all identified by a single integer. To support
      this, defer the parsing of the device string to the IO backed, so that
      it can apply the appropriate rules.
      SPI devices are specified as controller:chip_select. SPI/SF support will
      be added soon.
      MMC devices can also be specified as controller[.hwpart][:partition] in
      many commands, although we don't support that syntax in DFU.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      dfu: add write error handling · 3ee9593f
      Stephen Warren authored
      Fix calls to dfu_write() and dfu_flush() to detect errors in the I/O
      itself. This could happen due to problems with the storage medium, or
      simply when trying to write a FAT/ext file that is larger than the buffer
      dfu_mmc.c maintains for this purpose.
      Signal the error by switching the DFU state/status. This will be picked
      up by the DFU client when it sends the next DFU request. Note that errors
      can't simply be returned from e.g. dnload_request_complete(), since that
      function has no way to pass errors back to the DFU client; a call to
      dnload_request_complete() simply means that a USB OUT completed.
      This error state/status needs to be cleared when the next DFU client
      connects. While there is a DFU_CLRSTATUS request, no DFU client seems to
      send this. Hence, clear this when selecting the USB alternate setting on
      the USB interface.
      Finally, dfu.c relies on a call to dfu_flush() to clear up the internal
      state of the write transaction. Now that errors in dfu_write() are
      detected, dfu_flush() may no longer be called for every transaction.
      Separate out the cleanup code into a new function, and call it whenever
      dfu_write() fails, as well as from any call to dfu_flush().
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      dfu: fix some issues with reads/uploads · 0e285b50
      Stephen Warren authored
      DFU read support appears to rely upon dfu->read_medium() updating the
      passed-by-reference len parameter to indicate the remaining size
      available for reading.
      dfu_read_medium_mmc() never does this, and the implementation of
      dfu_read_medium_nand() will only work if called just once; it hard-codes
      the value to the total size of the NAND device irrespective of read
      I believe that overloading dfu->read_medium() is confusing. As such,
      this patch introduces a new function dfu->get_medium_size() which can
      be used to explicitly find out the medium size, and nothing else.
      dfu_read() is modified to use this function to set the initial value for
      dfu->r_left, rather than attempting to use the side-effects of
      dfu->read_medium() for this purpose.
      Due to this change, dfu_read() must initially set dfu->b_left to 0, since
      no data has been read.
      dfu_read_buffer_fill() must also be modified not to adjust dfu->r_left
      when simply copying data from dfu->i_buf_start to the upload request
      buffer. r_left represents the amount of data left to be read from HW.
      That value is not affected by the memcpy(), but only by calls to
      After this change, I can read from either a 4MB or 1.5MB chunk of a 4MB
      eMMC boot partion with CONFIG_SYS_DFU_DATA_BUF_SIZE==1MB. Without this
      change, attempting to do that would result in DFU read returning no data
      at all due to r_left never being set.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    • Stephen Warren's avatar
      fs: implement size/fatsize/ext4size · cf659819
      Stephen Warren authored
      These commands may be used to determine the size of a file without
      actually reading the whole file content into memory. This may be used
      to determine if the file will fit into the memory buffer that will
      contain it. In particular, the DFU code will use it for this purpose
      in the next commit.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
  2. 06 Aug, 2014 8 commits
  3. 05 Aug, 2014 4 commits