1. 09 Aug, 2014 1 commit
    • Stephen Warren's avatar
      net: BOOTP retry timeout improvements · f59be6e8
      Stephen Warren authored
      Currently, the BOOTP code sends out its initial request as soon as the
      Ethernet driver indicates "link up". If this packet is lost or not
      replied to for some reason, the code waits for a 1s timeout before
      retrying. For some reason, such early packets are often lost on my
      system, so this causes an annoying delay.
      
      To optimize this, modify the BOOTP code to have very short timeouts for
      the first packet transmitted, but gradually increase the timeout each
      time a timeout occurs. This way, if the first packet is lost, the second
      packet is transmitted quite quickly and hence the overall delay is low.
      However, if there's still no response, we don't keep spewing out packets
      at an insane speed.
      
      It's arguably more correct to try and find out why the first packet is
      lost. However, it seems to disappear inside my Ethenet chip; the TX chip
      indicates no error during TX (not that it has much in the way of
      reporting...), yet wireshark on the RX side doesn't see any packet.
      FWIW, I'm using an ASIX USB Ethernet adapter. Perhaps "link up" is
      reported too early or based on the wrong condition in HW, and we should
      add some fixed extra delay into the driver. However, this would slow down
      every link up event even if it ends up not being needed in some cases.
      Having BOOTP retry quickly applies the fix/WAR to every possible
      Ethernet device, and is quite simple to implement, so seems a better
      solution.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Acked-by: default avatarJoe Hershberger <joe.hershberger@ni.com>
      f59be6e8
  2. 22 Jul, 2014 1 commit
  3. 02 Apr, 2014 1 commit
    • Przemyslaw Marczak's avatar
      lib: uuid: code refactor for proper maintain between uuid bin and string · d718ded0
      Przemyslaw Marczak authored
      Changes in lib/uuid.c to:
      - uuid_str_to_bin()
      - uuid_bin_to_str()
      
      New parameter is added to specify input/output string format in listed functions
      This change allows easy recognize which UUID type is or should be stored in given
      string array. Binary data of UUID and GUID is always stored in big endian, only
      string representations are different as follows.
      
      String byte: 0                                  36
      String char: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
      string UUID:    be     be   be   be       be
      string GUID:    le     le   le   be       be
      
      This patch also updates functions calls and declarations in a whole code.
      Signed-off-by: default avatarPrzemyslaw Marczak <p.marczak@samsung.com>
      Cc: Stephen Warren <swarren@nvidia.com>
      Cc: Lukasz Majewski <l.majewski@samsung.com>
      Cc: trini@ti.com
      d718ded0
  4. 04 Nov, 2012 1 commit
    • Kim Phillips's avatar
      net/: sparse fixes · 06370590
      Kim Phillips authored
      bootp.c:44:14: warning: symbol 'dhcp_state' was not declared. Should it be static?
      bootp.c:45:15: warning: symbol 'dhcp_leasetime' was not declared. Should it be static?
      bootp.c:46:10: warning: symbol 'NetDHCPServerIP' was not declared. Should it be static?
      arp.c:30:17: warning: symbol 'NetArpWaitReplyIP' was not declared. Should it be static?
      arp.c:37:16: warning: symbol 'NetArpTxPacket' was not declared. Should it be static?
      arp.c:38:17: warning: symbol 'NetArpPacketBuf' was not declared. Should it be static?
      atheros.c:33:19: warning: symbol 'AR8021_driver' was not declared. Should it be static?
      net.c:183:7: warning: symbol 'PktBuf' was not declared. Should it be static?
      net.c:159:21: warning: symbol 'net_state' was not declared. Should it be static?
      ping.c:73:6: warning: symbol 'ping_start' was not declared. Should it be static?
      ping.c:82:13: warning: symbol 'ping_receive' was not declared. Should it be static?
      tftp.c:53:7: warning: symbol 'TftpRRQTimeoutMSecs' was not declared. Should it be static?
      tftp.c:54:5: warning: symbol 'TftpRRQTimeoutCountMax' was not declared. Should it be static?
      eth.c:125:19: warning: symbol 'eth_current' was not declared. Should it be static?
      
      Note: in the ping.c fix, commit a36b12f9
      "net: Move PING out of net.c" mistakenly carried the ifdef CMD_PING
      clause from when it was necessary to avoid warnings when it was embedded
      in net.c.
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      06370590
  5. 01 Oct, 2012 2 commits
  6. 27 Sep, 2012 1 commit
    • Brian Rzycki's avatar
      net: Quietly ignore DHCP Option 28 (Broadcast Address) · ee0f60df
      Brian Rzycki authored
      Some DHCP servers (notably dnsmasq) always transmit DHCP Option 28,
      Broadcast Address as specified in RFC 2132. Without this patch u-boot
      displays the warning:
        *** Unhandled DHCP Option in OFFER/ACK: 28
      
      The patch suppresses the warning and ignores DHCP Option 28. There is
      no environment variable to set the broadcast address into and if for
      some reason u-boot needs the broadcast it can be calculated from
      ipaddr and netmask.
      Signed-off-by: default avatarBrian Rzycki <bmr@freescale.com>
      ee0f60df
  7. 19 Jul, 2012 1 commit
  8. 08 Jul, 2012 1 commit
    • Kim Phillips's avatar
      net: make net_rand.h inclusion depend on BOOTP_RANDOM_DELAY · db7720ba
      Kim Phillips authored
      commit "net: use common rand()/srand() functions" introduced the following
      build warning on the current u-boot-arm tree:
      
      $ ./MAKEALL MPC8313ERDB_66
      Configuring for MPC8313ERDB_66 - Board: MPC8313ERDB, Options: SYS_66MHZ
         text	   data	    bss	    dec	    hex	filename
       271988	  13976	  41768	 327732	  50034	./u-boot
      In file included from bootp.c:15:0:
      net_rand.h: In function 'srand_mac':
      net_rand.h:40:2: warning: implicit declaration of function 'srand' [-Wimplicit-function-declaration]
      
      adding this dependency fixes it.
      
      Cc: Michael Walle <michael@walle.cc>
      Cc: Joe Hershberger <joe.hershberger@ni.com>
      Signed-off-by: default avatarKim Phillips <kim.phillips@freescale.com>
      Acked-by: default avatarMichael Walle <michael@walle.cc>
      db7720ba
  9. 23 May, 2012 10 commits
  10. 15 May, 2012 2 commits
  11. 18 Mar, 2012 1 commit
  12. 23 Nov, 2011 1 commit
  13. 27 Oct, 2011 1 commit
  14. 26 Oct, 2011 1 commit
  15. 17 Oct, 2011 1 commit
  16. 19 Sep, 2011 1 commit
  17. 08 Aug, 2011 1 commit
  18. 27 Jul, 2011 1 commit
  19. 12 May, 2011 1 commit
  20. 13 Apr, 2011 1 commit
  21. 14 Nov, 2010 1 commit
  22. 14 Dec, 2009 1 commit
  23. 03 Oct, 2009 1 commit
  24. 11 Sep, 2009 1 commit
  25. 08 Aug, 2009 1 commit
    • Robin Getz's avatar
      minor debug cleanups in ./net · 0ebf04c6
      Robin Getz authored
       Minor ./net cleanups - no functional changes
        - change #ifdef DEBUG printf(); #endif to just debug()
        - changed __FUNCTION__ to __func__
        - got rid of extra whitespace between function and opening brace
        - removed unnecessary braces on if statements
      
       gcc dead code elimination should make this functionally/size equivalent
       when DEBUG is not defined. (confirmed on Blackfin, with gcc 4.3.3).
      Signed-off-by: default avatarRobin Getz <rgetz@blackfin.uclinux.org>
      Signed-off-by: default avatarBen Warren <biggerbadderben@gmail.com>
      0ebf04c6
  26. 23 Jul, 2009 1 commit
  27. 15 Jun, 2009 1 commit
  28. 20 Mar, 2009 2 commits