checkpatch.py 6.08 KB
Newer Older
1 2
# Copyright (c) 2011 The Chromium OS Authors.
#
3
# SPDX-License-Identifier:	GPL-2.0+
4 5
#

6
import collections
7 8 9 10
import command
import gitutil
import os
import re
11
import sys
12 13 14
import terminal

def FindCheckPatch():
15
    top_level = gitutil.GetTopLevel()
16 17 18
    try_list = [
        os.getcwd(),
        os.path.join(os.getcwd(), '..', '..'),
19 20
        os.path.join(top_level, 'tools'),
        os.path.join(top_level, 'scripts'),
21 22 23 24 25 26 27 28 29 30 31 32 33 34 35
        '%s/bin' % os.getenv('HOME'),
        ]
    # Look in current dir
    for path in try_list:
        fname = os.path.join(path, 'checkpatch.pl')
        if os.path.isfile(fname):
            return fname

    # Look upwwards for a Chrome OS tree
    while not os.path.ismount(path):
        fname = os.path.join(path, 'src', 'third_party', 'kernel', 'files',
                'scripts', 'checkpatch.pl')
        if os.path.isfile(fname):
            return fname
        path = os.path.dirname(path)
36

37 38
    sys.exit('Cannot find checkpatch.pl - please put it in your ' +
             '~/bin directory or use --no-check')
39 40 41 42 43

def CheckPatch(fname, verbose=False):
    """Run checkpatch.pl on a file.

    Returns:
44 45
        namedtuple containing:
            ok: False=failure, True=ok
46 47 48 49 50
            problems: List of problems, each a dict:
                'type'; error or warning
                'msg': text message
                'file' : filename
                'line': line number
51 52 53
            errors: Number of errors
            warnings: Number of warnings
            checks: Number of checks
54
            lines: Number of lines
55
            stdout: Full output of checkpatch
56
    """
57 58 59 60 61 62 63
    fields = ['ok', 'problems', 'errors', 'warnings', 'checks', 'lines',
              'stdout']
    result = collections.namedtuple('CheckPatchResult', fields)
    result.ok = False
    result.errors, result.warning, result.checks = 0, 0, 0
    result.lines = 0
    result.problems = []
64 65
    chk = FindCheckPatch()
    item = {}
66 67
    result.stdout = command.Output(chk, '--no-tree', fname,
                                   raise_on_error=False)
68 69 70 71
    #pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE)
    #stdout, stderr = pipe.communicate()

    # total: 0 errors, 0 warnings, 159 lines checked
72 73
    # or:
    # total: 0 errors, 2 warnings, 7 checks, 473 lines checked
74
    re_stats = re.compile('total: (\\d+) errors, (\d+) warnings, (\d+)')
75 76
    re_stats_full = re.compile('total: (\\d+) errors, (\d+) warnings, (\d+)'
                               ' checks, (\d+)')
77 78 79 80
    re_ok = re.compile('.*has no obvious style problems')
    re_bad = re.compile('.*has style problems, please review')
    re_error = re.compile('ERROR: (.*)')
    re_warning = re.compile('WARNING: (.*)')
81
    re_check = re.compile('CHECK: (.*)')
82 83
    re_file = re.compile('#\d+: FILE: ([^:]*):(\d+):')

84
    for line in result.stdout.splitlines():
85
        if verbose:
86
            print(line)
87 88 89

        # A blank line indicates the end of a message
        if not line and item:
90
            result.problems.append(item)
91
            item = {}
92 93 94
        match = re_stats_full.match(line)
        if not match:
            match = re_stats.match(line)
95
        if match:
96 97 98 99 100 101 102
            result.errors = int(match.group(1))
            result.warnings = int(match.group(2))
            if len(match.groups()) == 4:
                result.checks = int(match.group(3))
                result.lines = int(match.group(4))
            else:
                result.lines = int(match.group(3))
103
        elif re_ok.match(line):
104
            result.ok = True
105
        elif re_bad.match(line):
106 107 108 109 110 111 112
            result.ok = False
        err_match = re_error.match(line)
        warn_match = re_warning.match(line)
        file_match = re_file.match(line)
        check_match = re_check.match(line)
        if err_match:
            item['msg'] = err_match.group(1)
113
            item['type'] = 'error'
114 115
        elif warn_match:
            item['msg'] = warn_match.group(1)
116
            item['type'] = 'warning'
117 118 119 120 121 122
        elif check_match:
            item['msg'] = check_match.group(1)
            item['type'] = 'check'
        elif file_match:
            item['file'] = file_match.group(1)
            item['line'] = int(file_match.group(2))
123

124
    return result
125 126 127 128 129 130 131 132 133 134 135 136 137 138

def GetWarningMsg(col, msg_type, fname, line, msg):
    '''Create a message for a given file/line

    Args:
        msg_type: Message type ('error' or 'warning')
        fname: Filename which reports the problem
        line: Line number where it was noticed
        msg: Message to report
    '''
    if msg_type == 'warning':
        msg_type = col.Color(col.YELLOW, msg_type)
    elif msg_type == 'error':
        msg_type = col.Color(col.RED, msg_type)
139 140
    elif msg_type == 'check':
        msg_type = col.Color(col.MAGENTA, msg_type)
141
    return '%s:%d: %s: %s\n' % (fname, line, msg_type, msg)
142 143 144

def CheckPatches(verbose, args):
    '''Run the checkpatch.pl script on each patch'''
145
    error_count, warning_count, check_count = 0, 0, 0
146 147 148
    col = terminal.Color()

    for fname in args:
149 150 151 152 153
        result = CheckPatch(fname, verbose)
        if not result.ok:
            error_count += result.errors
            warning_count += result.warnings
            check_count += result.checks
154 155
            print('%d errors, %d warnings, %d checks for %s:' % (result.errors,
                    result.warnings, result.checks, col.Color(col.BLUE, fname)))
156 157
            if (len(result.problems) != result.errors + result.warnings +
                    result.checks):
158
                print("Internal error: some problems lost")
159
            for item in result.problems:
160 161
                sys.stderr.write(
                    GetWarningMsg(col, item.get('type', '<unknown>'),
162
                        item.get('file', '<unknown>'),
163
                        item.get('line', 0), item.get('msg', 'message')))
164
            print
165
            #print(stdout)
166 167
    if error_count or warning_count or check_count:
        str = 'checkpatch.pl found %d error(s), %d warning(s), %d checks(s)'
168 169 170 171 172
        color = col.GREEN
        if warning_count:
            color = col.YELLOW
        if error_count:
            color = col.RED
173
        print(col.Color(color, str % (error_count, warning_count, check_count)))
174 175
        return False
    return True