Skip to content
  • Heiko Schocher's avatar
    serial, ns16550: bugfix: ns16550 fifo not enabled · 17fa0326
    Heiko Schocher authored
    commit: 65f83802
    
     "serial: 16550: Add getfcr accessor"
    breaks u-boot commandline working with long commands
    sending to the board.
    
    Since the above patch, you have to setup the fcr register.
    
    For board/archs which enable OF_PLATDATA, the new field
    fcr in struct ns16550_platdata is not filled with a
    default value ...
    
    This leads in not setting up the uarts fifo, which ends
    in problems, when you send long commands to u-boots
    commandline.
    
    Detected this issue with automated tbot tests on am335x
    based shc board.
    
    The error does not popup, if you type commands. You need
    to copy&paste a long command to u-boots commandshell
    (or send a long command with tbot)
    
    Possible boards/plattforms with problems:
    ./arch/arm/cpu/arm926ejs/lpc32xx/devices.c
    ./arch/arm/mach-tegra/board.c
    ./board/overo/overo.c
    ./board/quipos/cairo/cairo.c
    ./board/logicpd/omap3som/omap3logic.c
    ./board/logicpd/zoom1/zoom1.c
    ./board/timll/devkit8000/devkit8000.c
    ./board/lg/sniper/sniper.c
    ./board/ti/beagle/beagle.c
    ./drivers/serial/serial_rockchip.c
    
    Signed-off-by: default avatarHeiko Schocher <hs@denx.de>
    Signed-off-by: default avatarLadislav Michl <ladis@linux-mips.org>
    Tested-by: default avatarAdam Ford <aford173@gmail.com>
    Reviewed-by: default avatarTom Rini <trini@konsulko.com>
    17fa0326