Skip to content
  • Nikita Kiryanov's avatar
    spi: mxc: fix sf probe when using mxc_spi · 155fa9af
    Nikita Kiryanov authored
    
    
    MXC SPI driver has a feature whereas a GPIO line can be used to force CS high
    across multiple transactions. This is set up by embedding the GPIO information
    in the CS value:
    
    cs = (cs | gpio << 8)
    
    This merge of cs and gpio data into one value breaks the sf probe command:
    if the use of gpio is required, invoking "sf probe <cs>" will not work, because
    the CS argument doesn't have the GPIO information in it. Instead, the user must
    use "sf probe <cs | gpio << 8>". For example, if bank 2 gpio 30 is used to force
    cs high on cs 0, bus 0, then instead of typing "sf probe 0" the user now must
    type "sf probe 15872".
    
    This is inconsistent with the description of the sf probe command, and forces
    the user to be aware of implementaiton details.
    
    Fix this by introducing a new board function: board_spi_cs_gpio(), which will
    accept a naked CS value, and provide the driver with the relevant GPIO, if one
    is necessary.
    
    Cc: Eric Nelson <eric.nelson@boundarydevices.com>
    Cc: Eric Benard <eric@eukrea.com>
    Cc: Fabio Estevam <fabio.estevam@freescale.com>
    Cc: Tim Harvey <tharvey@gateworks.com>
    Cc: Stefano Babic <sbabic@denx.de>
    Cc: Tom Rini <trini@ti.com>
    Cc: Marek Vasut <marex@denx.de>
    Reviewed-by: default avatarMarek Vasut <marex@denx.de>
    Signed-off-by: default avatarNikita Kiryanov <nikita@compulab.co.il>
    Reviewed-by: default avatarJagannadha Sutradharudu Teki <jaganna@xilinx.com>
    155fa9af