• Lukasz Majewski's avatar
    dfu: usb: f_dfu: Set deferred call for dfu_flush() function · fc18f8d1
    Lukasz Majewski authored
    This patch fixes situation when one would like to write large file into
    medium with the file system (fat, ext4, etc).
    This change sets file size limitation to the DFU internal buffer size.
    Since u-boot is not supporting interrupts and seek on file systems, it
    becomes challenging to store large file appropriately.
    To reproduce this error - create large file (around 26 MiB) and sent it
    to the target board.
    Lets examine the flow of USB transactions:
    0. DFU uses EP0 with 64B MPS [Max Packet Size]
    1. Send file - OUT (PC->target) - dat_26MiB.img is sent with 4096 B transactions
    2. Get status - OUT (PC->target) - wait for DFU_STATE_dfuDNLOAD_IDLE (0x05) sent
    				   from target board - IN transaction
    3. The whole file content is sent to target - OUT (PC->target) with ZLP [Zero
    					      Length Packet]
    Now the interesting part starts:
    4. OUT (PC->target) Setup transaction (request to share DFU state)
    5. IN (target->PC) - reply the current DFU state
    	- In the UDC driver the req->completion (with dfu_flush) is called
    	  after successful IN transfer.
    	- The dfu_flush() (called from req->completion callback) saves the
    	  whole file at once (u-boot doesn't support seek on fs).
    	  Such operation takes considerable time. When the file
    	  is large - e.g. 26MiB - this time may be more than 5 seconds.
    6. OUT (PC->target) - ZLP, is send in the same time when dfu_flush()
     writes data to eMMC memory.
     The dfu-util application has hard coded timeout on USB transaction
     completion set to 5 seconds (it uses libusb calls).
    When the file to store is large (e.g. 26 MiB) the time needed to write it
    may excess the dfu-util timeout and following error message will be displayed:
    "unable to read DFU status" on the HOST PC console.
    This change is supposed to leverage DFU's part responsible for storing files
    on file systems. Other DFU operations - i.e. raw/partition write to NAND and
    eMMC should work as before.
    The only functional change is the error reporting. When dfu_flush() fails
    the u-boot prompt will exit with error information and dfu-util application
    exits afterwards as well.
    Test HW:
    - Odroid XU3 (Exynos5433) - test with large file
    - Trats (Exynos4210) - test for regression - eMMC, raw,
    Signed-off-by: default avatarLukasz Majewski <l.majewski@samsung.com>
    Reported-by: default avatarAlex Gdalevich <agdalevich@axion-biosystems.com>
    Tested-by: default avatarStephen Warren <swarren@nvidia.com>
    Tested-by: default avatarHeiko Schocher <hs@denx.de>
dfu.h 6.59 KB