Commit 4b29bdb0 authored by Kumar Gala's avatar Kumar Gala Committed by Wolfgang Denk

net: e1000: Add initialized eth_device & e1000_hw structure

nic and hw structures are allocated via malloc i.e. return memory
is not zero initialized. Because of this few structure member like
"function pointers" are initialized with garbage values.

It may cause problem. for eg. during eth_initialize, dev->write_hwaddr
is used.
Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>

Fixed typo.
Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
parent fe7f1883
......@@ -5177,7 +5177,21 @@ e1000_initialize(bd_t * bis)
}
nic = (struct eth_device *) malloc(sizeof (*nic));
if (!nic) {
printf("Error: e1000 - Can not alloc memory\n");
return 0;
}
hw = (struct e1000_hw *) malloc(sizeof (*hw));
if (!hw) {
free(nic);
printf("Error: e1000 - Can not alloc memory\n");
return 0;
}
memset(nic, 0, sizeof(*dev));
memset(hw, 0, sizeof(*hw));
hw->pdev = devno;
nic->priv = hw;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment