Commit 5abab20d authored by Simon Glass's avatar Simon Glass

buildman: Allow specifying a range of commits to build

Adjust the -b flag to permit a range expression as well as a branch.
Signed-off-by: default avatarSimon Glass <>
Suggested-by: default avatarDaniel Schwierzeck <>
Tested-by: default avatarDaniel Schwierzeck <>
parent 0740127f
......@@ -699,6 +699,17 @@ build the selected boards and display build status as it runs (i.e. -v is
enabled automatically). Use -e to see errors/warnings as well.
Building Ranges
You can build a range of commits by specifying a range instead of a branch
when using the -b flag. For example:
will build commits in us-buildman that are not in upstream/master.
Other options
......@@ -123,14 +123,22 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
# problems introduced by the first commit on the branch.
col = terminal.Color()
count = options.count
has_range = options.branch and '..' in options.branch
if count == -1:
if not options.branch:
count = 1
count, msg = gitutil.CountCommitsInBranch(options.git_dir,
if has_range:
count, msg = gitutil.CountCommitsInRange(options.git_dir,
count, msg = gitutil.CountCommitsInBranch(options.git_dir,
if count is None:
sys.exit(col.Color(col.RED, msg))
elif count == 0:
sys.exit(col.Color(col.RED, "Range '%s' has no commits" %
if msg:
print col.Color(col.YELLOW, msg)
count += 1 # Build upstream commit also
......@@ -172,8 +180,11 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
# to overwrite earlier ones by setting allow_overwrite=True
if options.branch:
if count == -1:
range_expr = gitutil.GetRangeInBranch(options.git_dir,
if has_range:
range_expr = options.branch
range_expr = gitutil.GetRangeInBranch(options.git_dir,
upstream_commit = gitutil.GetUpstream(options.git_dir,
series = patchstream.GetMetaDataForList(upstream_commit,
......@@ -154,6 +154,24 @@ def GetRangeInBranch(git_dir, branch, include_upstream=False):
rstr = '%s%s..%s' % (upstream, '~' if include_upstream else '', branch)
return rstr, msg
def CountCommitsInRange(git_dir, range_expr):
"""Returns the number of commits in the given range.
git_dir: Directory containing git repo
range_expr: Range to check
Number of patches that exist in the supplied rangem or None if none
were found
pipe = [LogCmd(range_expr, git_dir=git_dir, oneline=True)]
result = command.RunPipe(pipe, capture=True, capture_stderr=True,
if result.return_code:
return None, "Range '%s' not found or is invalid" % range_expr
patch_count = len(result.stdout.splitlines())
return patch_count, None
def CountCommitsInBranch(git_dir, branch, include_upstream=False):
"""Returns the number of commits in the given branch.
......@@ -167,11 +185,7 @@ def CountCommitsInBranch(git_dir, branch, include_upstream=False):
range_expr, msg = GetRangeInBranch(git_dir, branch, include_upstream)
if not range_expr:
return None, msg
pipe = [LogCmd(range_expr, git_dir=git_dir, oneline=True),
['wc', '-l']]
result = command.RunPipe(pipe, capture=True, oneline=True)
patch_count = int(result.stdout)
return patch_count, msg
return CountCommitsInRange(git_dir, range_expr)
def CountCommits(commit_range):
"""Returns the number of commits in the given range.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment