Commit 9c720c81 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Jaehoon Chung

mmc: uniphier-sd: fix Kconfig dependency

Some MMC drivers describe operations with the DM_MMC_OPS form, but
there are still several drivers with older implementation.  We can
not compile drivers from different groups at the same time because
the core framework is shared with #ifdef CONFIG_DM_MMC_OPS.

Every driver should have "depends on DM_MMC_OPS" (or !DM_MMC_OPS)
explicitly to express which framework it is based on.  This will
avoid enabling drivers with incompatible interface at the same time.
It is incorrect to make a driver "select DM_MMC_OPS".

While we are here, add "depends on OF_CONTROL" as well because this
driver can be configured only by Device Tree.
Signed-off-by: default avatarMasahiro Yamada <>
parent e5e7a7c2
......@@ -107,8 +107,8 @@ config ROCKCHIP_SDHCI
bool "UniPhier SD/MMC Host Controller support"
depends on ARCH_UNIPHIER
depends on BLK
select DM_MMC_OPS
depends on BLK && DM_MMC_OPS
depends on OF_CONTROL
This selects support for the SD/MMC Host Controller on UniPhier SoCs.
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment