Commit cc4e6b37 authored by Ye Li's avatar Ye Li Committed by Jason Liu

MLK-16219 pca953x_gpio: Clear the polarity invert register at init

The pca953x_gpio driver uses default value of polarity inversion register.
For some devices like PCA9557 and MAX7310, their polarity inversion register
default value is 0xf0. So for high 4 ports, when reading their values,
the values are inverted as the actual level.

This patch clears the polarity inversion register to 0 at init. So that the port read
and write values are aligned.
Signed-off-by: default avatarYe Li <>
Acked-by: default avatarFugang Duan <>
Acked-by: default avatarPeng Fan <>
parent 40a60b20
......@@ -132,6 +132,26 @@ static int pca953x_read_regs(struct udevice *dev, int reg, u8 *val)
return ret;
static int pca953x_write_regs(struct udevice *dev, int reg, u8 *val)
struct pca953x_info *info = dev_get_platdata(dev);
int ret = 0;
if (info->gpio_count <= 8) {
ret = dm_i2c_write(dev, reg, val, 1);
} else if (info->gpio_count <= 16) {
ret = dm_i2c_write(dev, reg << 1, val, info->bank_count);
} else if (info->gpio_count == 40) {
/* Auto increment */
ret = dm_i2c_write(dev, (reg << 3) | 0x80, val, info->bank_count);
} else {
dev_err(dev, "Unsupported now\n");
return -EINVAL;
return ret;
static int pca953x_is_output(struct udevice *dev, int offset)
struct pca953x_info *info = dev_get_platdata(dev);
......@@ -254,6 +274,7 @@ static int pca953x_probe(struct udevice *dev)
int addr;
ulong driver_data;
int ret;
u8 val[MAX_BANK];
if (!info) {
dev_err(dev, "platdata not ready\n");
......@@ -299,6 +320,14 @@ static int pca953x_probe(struct udevice *dev)
return ret;
/* Clear the polarity registers to no invert */
memset(val, 0, MAX_BANK);
ret = pca953x_write_regs(dev, PCA953X_INVERT, &val);
if (ret) {
dev_err(dev, "Error writing invert register\n");
return ret;
snprintf(name, sizeof(name), "gpio@%x_", info->addr);
str = strdup(name);
if (!str)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment