1. 25 Jan, 2016 2 commits
  2. 24 Jul, 2013 1 commit
  3. 06 Mar, 2012 1 commit
  4. 24 Jul, 2010 1 commit
  5. 04 Jul, 2010 1 commit
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  6. 12 Jun, 2009 1 commit
    • Wolfgang Denk's avatar
      General help message cleanup · a89c33db
      Wolfgang Denk authored
      Many of the help messages were not really helpful; for example, many
      commands that take no arguments would not print a correct synopsis
      line, but "No additional help available." which is not exactly wrong,
      but not helpful either.
      
      Commit ``Make "usage" messages more helpful.'' changed this
      partially. But it also became clear that lots of "Usage" and "Help"
      messages (fields "usage" and "help" in struct cmd_tbl_s respective)
      were actually redundant.
      
      This patch cleans this up - for example:
      
      Before:
      	=> help dtt
      	dtt - Digital Thermometer and Thermostat
      
      	Usage:
      	dtt         - Read temperature from digital thermometer and thermostat.
      
      After:
      	=> help dtt
      	dtt - Read temperature from Digital Thermometer and Thermostat
      
      	Usage:
      	dtt
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      a89c33db
  7. 28 Jan, 2009 2 commits
  8. 10 Sep, 2008 1 commit
  9. 21 Nov, 2007 1 commit
  10. 10 Jul, 2007 1 commit
  11. 08 Jul, 2007 1 commit
  12. 03 Jul, 2007 1 commit
  13. 01 Jul, 2003 1 commit
  14. 29 Jun, 2003 1 commit
  15. 31 May, 2003 1 commit
    • wdenk's avatar
      * Patch by Marc Singer, 29 May 2003: · 7a8e9bed
      wdenk authored
        Fixed rarp boot method for IA32 and other little-endian CPUs.
      
      * Patch by Marc Singer, 28 May 2003:
        Added port I/O commands.
      
      * Patch by Matthew McClintock, 28 May 2003
        - cpu/mpc824x/start.S: fix relocation code when booting from RAM
        - minor patches for utx8245
      
      * Patch by Daniel Engström, 28 May 2003:
        x86 update
      
      * Patch by Dave Ellis, 9 May 2003 + 27 May 2003:
        add nand flash support to SXNI855T configuration
        fix/extend nand flash support:
        - fix 'nand erase' command so does not erase bad blocks
        - fix 'nand write' command so does not write to bad blocks
        - fix nand_probe() so handles no flash detected properly
        - add doc/README.nand
        - add .jffs2 and .oob options to nand read/write
        - add 'nand bad' command to list bad blocks
        - add 'clean' option to 'nand erase' to write JFFS2 clean markers
        - make NAND read/write faster
      
      * Patch by Rune Torgersen, 23 May 2003:
        Update for MPC8266ADS board
      7a8e9bed