1. 02 Dec, 2016 2 commits
  2. 17 May, 2016 3 commits
  3. 16 Mar, 2016 1 commit
  4. 14 Mar, 2016 3 commits
  5. 25 Jan, 2016 2 commits
  6. 14 Jan, 2016 1 commit
  7. 12 Jan, 2016 1 commit
  8. 11 Jul, 2015 1 commit
    • Andre Przywara's avatar
      scsi: fix compiler warning with DEBUG and 48bit LBAs · c7d0fd79
      Andre Przywara authored
      Commit 2b42c931 ("ahci: support LBA48 data reads for 2+TB drives")
      introduced conditional code which triggers a warning when compiled
      with DEBUG enabled:
      
      In file included from common/cmd_scsi.c:12:0:
      common/cmd_scsi.c: In function 'scsi_read':
      include/common.h:109:4: warning: 'smallblks' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ...
      
      Since this is for debug only, take the easy way and initialize the
      variable explicitly on declaration to avoid the warning.
      (Fix a nearby whitespace error on the way.)
      Tested-by: default avatarBin Meng <bmeng.cn@gmail.com>
      Signed-off-by: default avatarAndre Przywara <osp@andrep.de>
      c7d0fd79
  9. 12 Jun, 2015 2 commits
  10. 22 Apr, 2015 1 commit
  11. 06 Feb, 2015 1 commit
  12. 27 Oct, 2014 1 commit
  13. 19 Feb, 2014 1 commit
  14. 24 Jul, 2013 1 commit
  15. 15 Jul, 2013 1 commit
    • Simon Glass's avatar
      scsi: Correct types of scsi_read/write() · 4f6aa346
      Simon Glass authored
      The block device expects to see lbaint_t for the blknr parameter. Change
      the SCSI read/write functions to suit.
      
      This fixes the following build warnings for coreboot:
      
      cmd_scsi.c: In function ‘scsi_scan’:
      cmd_scsi.c:119:30: error: assignment from incompatible pointer type [-Werror]
      cmd_scsi.c:120:32: error: assignment from incompatible pointer type [-Werror]
      Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
      4f6aa346
  16. 01 May, 2013 1 commit
  17. 01 Apr, 2013 1 commit
    • York Sun's avatar
      Consolidate bool type · 472d5460
      York Sun authored
      'bool' is defined in random places. This patch consolidates them into a
      single header file include/linux/types.h, using stdbool.h introduced in C99.
      
      All other #define, typedef and enum are removed. They are all consistent with
      true = 1, false = 0.
      
      Replace FALSE, False with false. Replace TRUE, True with true.
      Skip *.py, *.php, lib/* files.
      Signed-off-by: default avatarYork Sun <yorksun@freescale.com>
      472d5460
  18. 02 Nov, 2012 4 commits
  19. 25 Sep, 2012 1 commit
  20. 06 Mar, 2012 1 commit
  21. 26 Jul, 2011 1 commit
  22. 25 Jul, 2011 2 commits
  23. 11 Jan, 2011 1 commit
  24. 28 Nov, 2010 2 commits
  25. 24 Jul, 2010 1 commit
  26. 04 Jul, 2010 1 commit
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  27. 12 Jun, 2009 1 commit
    • Wolfgang Denk's avatar
      General help message cleanup · a89c33db
      Wolfgang Denk authored
      Many of the help messages were not really helpful; for example, many
      commands that take no arguments would not print a correct synopsis
      line, but "No additional help available." which is not exactly wrong,
      but not helpful either.
      
      Commit ``Make "usage" messages more helpful.'' changed this
      partially. But it also became clear that lots of "Usage" and "Help"
      messages (fields "usage" and "help" in struct cmd_tbl_s respective)
      were actually redundant.
      
      This patch cleans this up - for example:
      
      Before:
      	=> help dtt
      	dtt - Digital Thermometer and Thermostat
      
      	Usage:
      	dtt         - Read temperature from digital thermometer and thermostat.
      
      After:
      	=> help dtt
      	dtt - Read temperature from Digital Thermometer and Thermostat
      
      	Usage:
      	dtt
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      a89c33db
  28. 28 Jan, 2009 1 commit
    • Peter Tyser's avatar
      Command usage cleanup · 2fb2604d
      Peter Tyser authored
      Remove command name from all command "usage" fields and update
      common/command.c to display "name - usage" instead of
      just "usage". Also remove newlines from command usage fields.
      Signed-off-by: default avatarPeter Tyser <ptyser@xes-inc.com>
      2fb2604d