1. 06 Mar, 2012 1 commit
  2. 07 Nov, 2011 1 commit
    • Wolfgang Denk's avatar
      common/cmd_flash.c: Fix GCC 4.6 build warnings · 4f5710f7
      Wolfgang Denk authored
      Fix:
      cmd_flash.c:355:32: warning: 'info' may be used uninitialized in this
      function [-Wuninitialized]
      cmd_flash.c:354:10: warning: 'sect_first' may be used uninitialized in
      this function [-Wuninitialized]
      cmd_flash.c:354:10: warning: 'sect_last' may be used uninitialized in
      this function [-Wuninitialized]
      cmd_flash.c: In function 'do_protect':
      cmd_flash.c:540:9: warning: 'info' may be used uninitialized in this
      function [-Wuninitialized]
      cmd_flash.c:538:9: warning: 'sect_first' may be used uninitialized in
      this function [-Wuninitialized]
      cmd_flash.c:538:9: warning: 'sect_last' may be used uninitialized in
      this function [-Wuninitialized]
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      4f5710f7
  3. 01 Oct, 2011 1 commit
  4. 28 Jul, 2011 1 commit
  5. 19 Feb, 2011 1 commit
  6. 12 Oct, 2010 1 commit
  7. 20 Sep, 2010 1 commit
  8. 24 Jul, 2010 1 commit
  9. 04 Jul, 2010 1 commit
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  10. 21 May, 2010 1 commit
  11. 19 Jul, 2009 1 commit
  12. 18 Jul, 2009 1 commit
  13. 12 Jun, 2009 1 commit
    • Wolfgang Denk's avatar
      General help message cleanup · a89c33db
      Wolfgang Denk authored
      Many of the help messages were not really helpful; for example, many
      commands that take no arguments would not print a correct synopsis
      line, but "No additional help available." which is not exactly wrong,
      but not helpful either.
      
      Commit ``Make "usage" messages more helpful.'' changed this
      partially. But it also became clear that lots of "Usage" and "Help"
      messages (fields "usage" and "help" in struct cmd_tbl_s respective)
      were actually redundant.
      
      This patch cleans this up - for example:
      
      Before:
      	=> help dtt
      	dtt - Digital Thermometer and Thermostat
      
      	Usage:
      	dtt         - Read temperature from digital thermometer and thermostat.
      
      After:
      	=> help dtt
      	dtt - Read temperature from Digital Thermometer and Thermostat
      
      	Usage:
      	dtt
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      a89c33db
  14. 20 Mar, 2009 1 commit
  15. 28 Jan, 2009 2 commits
  16. 18 Oct, 2008 2 commits
  17. 06 Aug, 2008 1 commit
  18. 29 Jul, 2008 1 commit
  19. 14 Jul, 2008 1 commit
  20. 13 Jul, 2008 2 commits
  21. 10 Jul, 2008 1 commit
  22. 30 Mar, 2008 1 commit
    • Stelian Pop's avatar
      Fix CFG_NO_FLASH compilation. · 880cc438
      Stelian Pop authored
      Many Atmel boards have no "real" (NOR) flash on board, and rely only
      on DataFlash and NAND memories. This patch enables CFG_NO_FLASH to
      be present in a board configuration file, while still enabling flash
      commands like 'flinfo', 'protect', etc.
      Signed-off-by: default avatarStelian Pop <stelian@popies.net>
      880cc438
  23. 21 Nov, 2007 1 commit
  24. 11 Jul, 2007 1 commit
  25. 10 Jul, 2007 1 commit
  26. 08 Jul, 2007 1 commit
  27. 03 Jul, 2007 1 commit
  28. 12 Jun, 2007 1 commit
  29. 11 Apr, 2006 1 commit
    • Heiko Schocher's avatar
      Fixes common/cmd_flash.c: · bb74140d
      Heiko Schocher authored
         - fix some compiler/parser error, if using m68k tool chain
         - optical fix for protect on/off all messages, if using more
           then one bank
        Patch by Jens Scharsig, 28 July 2005
      bb74140d
  30. 01 Apr, 2006 1 commit
    • Stefan Roese's avatar
      * Changes/fixes for drivers/cfi_flash.c: · 2662b40c
      Stefan Roese authored
        - Add Intel legacy lock/unlock support to common CFI driver
      
          On some Intel flash's (e.g. Intel J3) legacy unlocking is
          supported, meaning that unlocking of one sector will unlock
          all sectors of this bank. Using this feature, unlocking
          of all sectors upon startup (via env var "unlock=yes") will
          get much faster.
      
        - Fixed problem with multiple reads of envronment variable
          "unlock" as pointed out by Reinhard Arlt & Anders Larsen.
      
        - Removed unwanted linefeeds from "protect" command when
          CFG_FLASH_PROTECTION is enabled.
      
        - Changed p3p400 board to use CFG_FLASH_PROTECTION
      
        Patch by Stefan Roese, 01 Apr 2006
      
      * Changes/fixes for drivers/cfi_flash.c:
        - Correctly handle the cases where CFG_HZ != 1000 (several
          XScale-based boards)
        - Fix the timeout calculation of buffered writes (off by a
          factor of 1000)
        Patch by Anders Larsen, 31 Mar 2006
      2662b40c
  31. 11 Oct, 2005 1 commit
  32. 10 Aug, 2005 1 commit
  33. 09 Aug, 2005 1 commit
  34. 07 Aug, 2005 1 commit
  35. 05 Aug, 2005 1 commit
  36. 02 Aug, 2005 1 commit
  37. 01 Aug, 2005 1 commit