1. 02 Jan, 2017 2 commits
  2. 27 Dec, 2016 2 commits
  3. 26 Dec, 2016 1 commit
  4. 19 Dec, 2016 9 commits
  5. 16 Dec, 2016 1 commit
  6. 09 Dec, 2016 2 commits
  7. 08 Dec, 2016 1 commit
    • Michal Simek's avatar
      tools: mkimage: Use fstat instead of stat to avoid malicious hacks · 37a2cf6f
      Michal Simek authored
      The patch is fixing:
      "tools: mkimage: Check if file is regular file"
      (sha1: 56c7e801)
      which contains two issues reported by Coverity
      Unchecked return value from stat and incorrect calling sequence where
      attack can happen between calling stat and fopen.
      Using pair in opposite order (fopen and fstat) is fixing this issue
      because fstat is using the same file descriptor (FILE *).
      
      Also fixing issue with:
      "tools: mkimage: Add support for initialization table for Zynq and
      ZynqMP" (sha1: 3b646080)
      where file wasn't checked that it is regular file.
      
      Reported-by: Coverity (CID: 154711, 154712)
      Signed-off-by: 's avatarMichal Simek <michal.simek@xilinx.com>
      Reviewed-by: 's avatarTom Rini <trini@konsulko.com>
      Series-to: trini
      Series-cc: u-boot
      37a2cf6f
  8. 03 Dec, 2016 1 commit
  9. 02 Dec, 2016 4 commits
  10. 01 Dec, 2016 2 commits
  11. 29 Nov, 2016 1 commit
  12. 28 Nov, 2016 2 commits
    • Max Krummenacher's avatar
      tools/env: fix environment alignment tests for block devices · 333ee16d
      Max Krummenacher authored
      commit 183923d3 enforces that the
      environment must start at an erase block boundary.
      
      For block devices the sample fw_env.config does not mandate a erase block size
      for block devices. A missing setting defaults to the full env size.
      
      Depending on the environment location the alignment check now errors out for
      perfectly legal settings.
      
      Fix this by defaulting to the standard blocksize of 0x200 for environments
      stored in a block device.
      That keeps the fw_env.config files for block devices working even with that
      new check.
      Signed-off-by: 's avatarMax Krummenacher <max.krummenacher@toradex.com>
      333ee16d
    • Andre Przywara's avatar
      tools/Makefile: suppress "which swig" error output · d0fc6dc5
      Andre Przywara authored
      The Makefile in tools/ tries to find the "swig" utility by calling "which".
      If nothing is found in the path, some versions of which will print an error
      message:
      $ make clean
      which: no swig in (/usr/local/bin:/usr/bin:/bin)
      
      This does not apply to all version of "which", though:
      $ echo $0
      bash
      $ type which
      which is aliased to `type -path'
      $ which foo				<== this version is OK
      $ /usr/bin/which foo			<== this one is chatty
      /usr/bin/which: no foo in (/usr/local/bin:/usr/bin:/bin)
      $ sh					<== make uses /bin/sh
      sh-4.3$ which foo			<== no alias here
      which: no foo in (/usr/local/bin:/usr/bin:/bin)
      
      This error message is rather pointless in our case, since we just have
      this very check to care for this. So add stderr redirection to suppress
      the message.
      Signed-off-by: 's avatarAndre Przywara <andre.przywara@arm.com>
      Reviewed-by: 's avatarSimon Glass <sjg@chromium.org>
      d0fc6dc5
  13. 24 Nov, 2016 1 commit
  14. 21 Nov, 2016 2 commits
  15. 15 Nov, 2016 2 commits
  16. 13 Nov, 2016 1 commit
  17. 06 Nov, 2016 2 commits
  18. 05 Nov, 2016 1 commit
    • Peng Fan's avatar
      tools: imximage: check return value when open the plugin file · 2a380ccc
      Peng Fan authored
      Check return value when open the plugin file.
      
      Coverity report:
      ** CID 153926:  Error handling issues  (NEGATIVE_RETURNS)
      /tools/imximage.c: 542 in copy_plugin_code()
      
         ifd = open(plugin_file, O_RDONLY|O_BINARY);
      >>>  CID 153926:  Error handling issues  (NEGATIVE_RETURNS)
      >>> "ifd" is passed to a parameter that cannot be negative.
      Signed-off-by: 's avatarPeng Fan <peng.fan@nxp.com>
      Cc: Stefano Babic <sbabic@denx.de>
      Cc: Tom Rini <trini@konsulko.com>
      Reported-by: Coverity (CID: 153926)
      Reviewed-by: 's avatarTom Rini <trini@konsulko.com>
      2a380ccc
  19. 31 Oct, 2016 2 commits
  20. 30 Oct, 2016 1 commit