1. 01 Apr, 2013 1 commit
    • York Sun's avatar
      Consolidate bool type · 472d5460
      York Sun authored
      'bool' is defined in random places. This patch consolidates them into a
      single header file include/linux/types.h, using stdbool.h introduced in C99.
      
      All other #define, typedef and enum are removed. They are all consistent with
      true = 1, false = 0.
      
      Replace FALSE, False with false. Replace TRUE, True with true.
      Skip *.py, *.php, lib/* files.
      Signed-off-by: default avatarYork Sun <yorksun@freescale.com>
      472d5460
  2. 09 Oct, 2011 1 commit
    • Stefan Roese's avatar
      ppc: Fix DBSR_IAx defines in <bedbug/regs.h> · 4b0a03d3
      Stefan Roese authored
      While adding asm/cache.h to common.h for PPC targets, I got an
      error about multiple definitions of some DBSR_ macros. While
      scanning these defines, I noticed that some where defined not
      correctly for all PPC variants. So I removed all unused defines,
      and corrected the ones really used by bedbug (book-e vs. ppc40x).
      Signed-off-by: default avatarStefan Roese <sr@denx.de>
      Cc: Wolfgang Denk <wd@denx.de>
      4b0a03d3
  3. 09 Sep, 2011 1 commit
    • Wolfgang Denk's avatar
      Fix warning: "assert" redefined · 5ae0dea3
      Wolfgang Denk authored
      Commit 21726a7a "Add assert() for debug assertions" caused build
      warnings for many systems:
      
      In file included from bedbug.c:6:
      /home/wd/git/u-boot/work/include/bedbug/bedbug.h:24:1: warning: "assert" redefined
      In file included from bedbug.c:3:
      /home/wd/git/u-boot/work/include/common.h:144:1: warning: this is the location of the previous definition
      In file included from cmd_bedbug.c:10:
      /home/wd/git/u-boot/work/include/bedbug/bedbug.h:24:1: warning: "assert" redefined
      In file included from cmd_bedbug.c:5:
      /home/wd/git/u-boot/work/include/common.h:144:1: warning: this is the location of the previous definition
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Cc: Simon Glass <sjg@chromium.org>
      Acked-by: default avatarSimon Glass <sjg@chromium.org>
      5ae0dea3
  4. 04 Jul, 2010 1 commit
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  5. 20 May, 2008 1 commit
    • Wolfgang Denk's avatar
      Big white-space cleanup. · 53677ef1
      Wolfgang Denk authored
      This commit gets rid of a huge amount of silly white-space issues.
      Especially, all sequences of SPACEs followed by TAB characters get
      removed (unless they appear in print statements).
      
      Also remove all embedded "vim:" and "vi:" statements which hide
      indentation problems.
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      53677ef1
  6. 27 Jun, 2003 1 commit
    • wdenk's avatar
      * Code cleanup: · 8bde7f77
      wdenk authored
        - remove trailing white space, trailing empty lines, C++ comments, etc.
        - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)
      
      * Patches by Kenneth Johansson, 25 Jun 2003:
        - major rework of command structure
          (work done mostly by Michal Cendrowski and Joakim Kristiansen)
      8bde7f77
  7. 17 Aug, 2002 1 commit
  8. 08 Mar, 2002 1 commit