Create librem5 board
Create an independent board for the Librem5 devkit.
The board code is copied from the Emcraft imx8m_som.
Merge request reports
Activity
mentioned in merge request !8 (merged)
I'm getting the following error when using the
librem5-base-defconfig
:CFG u-boot.cfg In file included from ./include/common.h:21: include/config.h:6:10: fatal error: configs/.h: No such file or directory #include <configs/.h> ^~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.autoconf:79: u-boot.cfg] Error 1 make: *** No rule to make target 'include/config/auto.conf', needed by 'include/config/uboot.release'. Stop.
Full log: test
Bump. @Bonstra am I doing something wrong to compile this?
Is there a reason not to name this board
librem5-devkit
instead of justlibrem5
?I was assuming the retail board would reuse most of the code from the devkit: we would keep the common code in
imx8_som.c
and put the sekeleton and device-specific code in newdevkit.c
andretail.c
(or any other better name than "retail").Bump. @Bonstra am I doing something wrong to compile this?
I'm getting the same error. I guess I didn't remove the .config before testing.
I had made a typo in the defconfig, should be fixed now…
I tested this, it works as advertised. @angus.ainslie or @guido.gunther do you agree?
mentioned in merge request !9 (merged)
mentioned in commit f3a75227
- board/purism/librem5/Kconfig 0 → 100644
1 if TARGET_PURISM_LIBREM5_DEVKIT 2 3 config SYS_BOARD 4 default "librem5" The idea was to avoid duplicating the board code again by having both
librem5_devkit
andlibrem5
(the final product) use the same board directory.The common parts would be kept as is, while the non-common parts would be put into their own file, which would be included or not in the build by the Makefile depending on the
TARGET_PURISM_LIBREM5_{DEVKIT,PHONE}
config defines.Though, given the relatively low amount of code in the board directory, maintaining the duplicated
librem5
andlibrem5_devkit
should still be manageable.What do you all think is the best approach? Duplicate or keep everything in the same directory?