• Steven Falco's avatar
    Prevent null pointer dereference originating in cmd_pxe.c · 0e3f3f8a
    Steven Falco authored
    Pass a valid cmdtp into do_tftpb(), do_ext2load(), and do_get_fat(), to
    avoid possible crashes due to null pointer dereferencing.
    
    Commit d7884e04 does not go far enough.
    There is still at least one call chain that can result in a crash.
    
    The do_tftpb(), do_ext2load(), and do_get_fat() functions expect a valid
    cmdtp.  Passing in NULL is particularly bad in the do_tftpb() case,
    because eventually boot_get_kernel() will be called with a NULL cmdtp:
    
    do_tftpb() -> netboot_common() -> bootm_maybe_autostart() -> do_bootm()
    -> do_bootm_states() -> bootm_find_os() -> boot_get_kernel()
    
    Around line 991 in cmd_bootm.c, boot_get_kernel() will dereference the
    null pointer, and the board will crash.
    Signed-off-by: default avatarSteven A. Falco <stevenfalco@gmail.com>
    0e3f3f8a
Name
Last commit
Last update
Licenses Loading commit data...
api Loading commit data...
arch Loading commit data...
board Loading commit data...
common Loading commit data...
disk Loading commit data...
doc Loading commit data...
drivers Loading commit data...
dts Loading commit data...
examples Loading commit data...
fs Loading commit data...
include Loading commit data...
lib Loading commit data...
nand_spl Loading commit data...
net Loading commit data...
post Loading commit data...
spl Loading commit data...
test Loading commit data...
tools Loading commit data...
.checkpatch.conf Loading commit data...
.gitignore Loading commit data...
CREDITS Loading commit data...
MAKEALL Loading commit data...
Makefile Loading commit data...
README Loading commit data...
boards.cfg Loading commit data...
config.mk Loading commit data...
mkconfig Loading commit data...
rules.mk Loading commit data...
snapshot.commit Loading commit data...