• Stephen Warren's avatar
    ARM: fix ifdefs in ARMv8 lowlevel_init() · 11661193
    Stephen Warren authored
    Commit 724219a6 "ARM: always perform per-CPU GIC init" removed some
    ifdefs to unify the MULTIENTRY-vs-non-MULTIENTRY paths. However, the
    wrong endif was removed. This patch adds back that missing endif, and
    adds a new ifdef to match the endif the now-correctly-terminated block
    used to match against. Use "git show -U25 724219a6" to see enough
    context to make the original issue clear.
    
    In practical terms, this makes no difference to runtime behaviour. The
    code that was incorrectly compiled into the binary when ifndef MULTIENTRY
    is a no-op for other cases, since branch_if_master evaluates to a hard-
    coded jump. The only issues were:
    
    - A few extra instructions were added to the binary.
    - The comment on the endif at the very end of the function, indicating
    which ifdef it matched, were wrong.
    
    An alternative might be to simply fix the comment on that trailing ifdef,
    but that only addresses the second point above, not the first.
    
    Fixes: 724219a6 ("ARM: always perform per-CPU GIC init")
    Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
    Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    Reviewed-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    11661193
Name
Last commit
Last update
..
arc Loading commit data...
arm Loading commit data...
avr32 Loading commit data...
blackfin Loading commit data...
m68k Loading commit data...
microblaze Loading commit data...
mips Loading commit data...
nds32 Loading commit data...
nios2 Loading commit data...
openrisc Loading commit data...
powerpc Loading commit data...
sandbox Loading commit data...
sh Loading commit data...
sparc Loading commit data...
x86 Loading commit data...
.gitignore Loading commit data...
Kconfig Loading commit data...