Jan Beich authored Jan 18, 2022 and Guido Gunther committed Jan 18, 2022

Ignored in Meson < 0.60.0, deprecated since 0.60.1 and fatal since 0.61.0.

data/meson.build:34:0: ERROR: Function does not take positional arguments.
data/meson.build:61:0: ERROR: Function does not take positional arguments.

Rename the Logo key to the Super Key

See merge request !34

This matches how it is typically called on free desktops.

Make virtboard wait properly wait  for wayland and glib events

Closes phosh#87 and #25

See merge request !33

The output_changed signale must have been processed to get a proper
scale.

Closes: #25

This makes sure we don't try to set the shown DBus property before the
DBus interface is ready.

Closes: phosh#87

Happens when hitting the keyboard button in the shell for the first
time:

    (process:18643): GLib-CRITICAL **: 12:07:38.152: g_source_remove: assertion 'tag > 0' failed

    Thread 1 "virtboard" received signal SIGTRAP, Trace/breakpoint trap.
    0x00007ffff78d8ca5 in _g_log_abort (breakpoint=1) at ../../../glib/gmessages.c:554
    554	../../../glib/gmessages.c: No such file or directory.
    (gdb) bt
    #0  0x00007ffff78d8ca5 in _g_log_abort (breakpoint=1) at ../../../glib/gmessages.c:554
    #1  0x00007ffff78d9fad in g_logv (log_domain=0x7ffff791e00e "GLib", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffd160) at ../../../glib/gmessages.c:1371
    #2  0x00007ffff78da17f in g_log (log_domain=log_domain@entry=0x7ffff791e00e "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7ffff79286bc "%s: assertion '%s' failed")
        at ../../../glib/gmessages.c:1413
    #3  0x00007ffff78da9a9 in g_return_if_fail_warning
        (log_domain=log_domain@entry=0x7ffff791e00e "GLib", pretty_function=pretty_function@entry=0x7ffff7926b90 <__FUNCTION__.13439> "g_source_remove", expression=expression@entry=0x7ffff7925dfd "tag > 0")
        at ../../../glib/gmessages.c:2762
    #4  0x00007ffff78d1be4 in g_source_remove (tag=<optimized out>) at ../../../glib/gmain.c:2352
    #5  0x0000555555571667 in window_inhibit_redraw (window=0x555555671280) at ../clients/window.c:3913
    #6  0x0000555555568a1d in make_surface (output=0x5555555c3310, virtual_keyboard=0x7fffffffdb80) at ../clients/keyboard.c:1114
    #7  0x0000555555568b5b in kb_window_create (virtual_keyboard=0x7fffffffdb80) at ../clients/keyboard.c:1137
    #8  0x0000555555568c9a in make_visible (keyboard=0x7fffffffdb80) at ../clients/keyboard.c:1166
    #9  0x0000555555569578 in handle_set_visible (object=0x5555556142a0, invocation=0x7fffe0009400 [GDBusMethodInvocation], arg_visible=1, user_data=0x7fffffffdb80) at ../clients/keyboard.c:1403
    #10 0x00007ffff747f8ee in ffi_call_unix64 () at /usr/lib/x86_64-linux-gnu/libffi.so.6
    #11 0x00007ffff747f2bf in ffi_call () at /usr/lib/x86_64-linux-gnu/libffi.so.6
    #15 0x00007ffff79d046f in Python Exception <class 'gdb.error'> There is no member named v_pointer.:
    #16 0x0000555555565295 in _sm_puri_osk0_skeleton_handle_method_call
        (connection=0x7fffe800b090 [GDBusConnection], sender=0x7fffe0004880 ":1.230", object_path=0x7fffe0007db0 "/sm/puri/OSK0", interface_name=0x7fffe0008150 "sm.puri.OSK0", method_name=0x7fffe0007d70 "SetVisible", parameters=0x555555620430, invocation=0x7fffe0009400 [GDBusMethodInvocation], user_data=0x5555556142a0) at sm.puri.OSK0.c:1136
    #17 0x00007ffff7b07b86 in g_dbus_interface_method_dispatch_helper
        (interface=<optimized out>, method_call_func=0x555555564e42 <_sm_puri_osk0_skeleton_handle_method_call>, invocation=0x7fffe0009400 [GDBusMethodInvocation]) at ../../../gio/gdbusinterfaceskeleton.c:609
    #18 0x00007ffff7aef199 in call_in_idle_cb (user_data=<optimized out>) at ../../../gio/gdbusconnection.c:4842
    #19 0x00007ffff78d2dd8 in g_main_dispatch (context=0x5555555de670) at ../../../glib/gmain.c:3182
    #20 0x00007ffff78d2dd8 in g_main_context_dispatch (context=context@entry=0x5555555de670) at ../../../glib/gmain.c:3847
    #21 0x00007ffff78d31c8 in g_main_context_iterate (context=0x5555555de670, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:3920
    #22 0x00007ffff78d34c2 in g_main_loop_run (loop=0x5555555de760) at ../../../glib/gmain.c:4116
    #23 0x00005555555759d1 in display_run (display=0x5555555bcef0) at ../clients/window.c:6080
    #24 0x0000555555569c6a in main (argc=1, argv=0x7fffffffdd28) at ../clients/keyboard.c:1578

dbus: Fix the location of schema

See merge request !32

Drew DeVault authored Feb 22, 2019 and Dorota Czaplejewicz committed Mar 03, 2019

More useful for use on sway

Drew DeVault authored Feb 16, 2019 and Dorota Czaplejewicz committed Feb 19, 2019

This will place the keyboard over fullscreen windows, and lock screens
(maybe).

Fix crashes when pressing tab

Closes #18

See merge request !28

Layouts: Fix crash on no layout set

See merge request !31

Updated bug template.

See merge request !30

Initialize the error holding variable

Closes #19

See merge request !29

The new template achieves the following:

- info to the bug reporter is commented out, making the report less cluttered
- adds info like the OS and compositor
- fixes some minor formatting issues

Fixes #19

This fixes momentary clicks which hide the keyboard, causing the button press never to be released.

It's still possible to get keys stuck by drag-and-dropping away from the original key.

Addresses the root cause of #18

Fixes crash when a widget would be free'd but a click event would still try to access it.

Partially fixes #18

The redraw procedure was allowed to run after a window was destroyed.

Partially addresses #18

Gsettings controls keyboard layouts

Closes #7

See merge request !25

Keymaps used by the virtual-keyboard protocol will now be changed whenever the keyboard layout changes. That allows for the symbols on the keys to match what the virtual-keyboard protocol produces.

This change adds "level 4" modifiers, normally resulting from combining AltGr and Shift. Because not all layouts need 4 levels, the key handling procedure becomes aware of the current layout. The added level can be accessed by pressing the AltGr key twice.

The change simplifies `label_from_key` calls in one go.

Fixes the bad generation of CTRL modifier.

Added Polish text-input layout to be able to see the change. The new layout does not have a new key map.

Switched main loop to glib

See merge request !24

Switched the dbus object implementation in one go, as it's easier and more useful than making sd-bus work with glib.