Hide the keyboard instead of making it small.

WIP status was because I think I saw a crash, but can't find it again.

added 1 commit

• 6341975c - Remove toggle button

Compare with previous version

changed the description

added 1 commit

• 62f8b26c - Bump version

Compare with previous version

Can we make this non WIP? The "disappear when unneeded" could even move in after the input method changes making this change rather minimal.

unmarked as a Work In Progress

changed the description

I removed the WIP, so whoever wants to merge should test for surprises. (hopefully I'll have time this week)

To keep track: It's been a week, but I haven't seen the bug. I haven't worked with this branch 100% of the time either. I'm going to try some tests and report back in another week.

Bug: pops back up instantly when an app supports text-input

Bug: pops back up instantly when an app supports text-input

Is that always or ony when the focus moves into an input field? I think the later is o.k. and intended (the whole hide/unhide button is a hack that will lead to these kind of problems)

I try to get around to do a review, ping me should I forget (we should IMHO aim for merging this next week latest if we don't find any more crashes)

It's only when the focus is on an input field. That's not what I had in mind - I wanted to let the user see the app in full size. Currently there's a nasty blink (resize) when this happens. But if you're fine with this, then I'm moving on.

It seems on startup the keyboard does show up visible but does not send a property change event to "visible" so the shell can't pick up that there's keyboard shown atm.

I think the right thing would be to not start visible. LGTM from a cursory look otherwise.

added 4 commits

• 75a90ca3 - Disappear when unneeded
• 41bcfff0 - Remove toggle button
• 6504a062 - Bump version
• 12a92f10 - Fix newline in session messages

Compare with previous version

Fixed, and I took the liberty of smuggling a commit fixing newlines, since it seems we'll get this merged before the other changes.

!22 (75a90ca3) has code movement which should have been split out to make it possible to review this in detail so I'm skipping this.

merged

mentioned in commit 1ccbb925

Cool we have the white bar on the bottom out of the way now.

Thanks - don't hesitate to block when I forget about code movement though.