wlroots issueshttps://source.puri.sm/Librem5/wlroots/-/issues2022-05-27T22:42:08Zhttps://source.puri.sm/Librem5/wlroots/-/issues/44Get rid of librem5-0.x.y branches2022-05-27T22:42:08ZGuido GuntherGet rid of librem5-0.x.y branchesSo far we've been maintaining the branch for embedded builds as well as the debian packaging separately. My suggestion would be to drop the librem5-0.x.y maintenance but rather publish the `patch-queue/pureos/<release>` branches (force p...So far we've been maintaining the branch for embedded builds as well as the debian packaging separately. My suggestion would be to drop the librem5-0.x.y maintenance but rather publish the `patch-queue/pureos/<release>` branches (force pusing when necessary). This makes the debian packaging the reference rather than following the embedded build (which already broke things in the past).https://source.puri.sm/Librem5/wlroots/-/issues/42left shift cannot be represented in type 'int'2020-11-16T19:27:06ZSebastian Krzyszkowiakleft shift cannot be represented in type 'int'UBsan reports:
```
../subprojects/wlroots/xcursor/xcursor.c:292:14: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
../subprojects/wlroots/render/gles2/texture.c:260:29: runtime error: left shift of 1 b...UBsan reports:
```
../subprojects/wlroots/xcursor/xcursor.c:292:14: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
../subprojects/wlroots/render/gles2/texture.c:260:29: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
```
That's with our 0.10 branch - it may be already fixed in newer wlroots.https://source.puri.sm/Librem5/wlroots/-/issues/41Touch input doesn't work when nested (Wayland)2020-11-09T16:51:47ZAlice MikhaylenkoTouch input doesn't work when nested (Wayland)Self-descriptive.
phoc and phosh from master, Fedora 33.Self-descriptive.
phoc and phosh from master, Fedora 33.https://source.puri.sm/Librem5/wlroots/-/issues/40Touch input when nested (X11) triggers pointer events as well2020-11-09T17:05:17ZAlice MikhaylenkoTouch input when nested (X11) triggers pointer events as wellTapping the screen moves the pointer to the tap location and triggers a pointer button press event there.
For example, https://source.puri.sm/Librem5/phosh/-/merge_requests/655#note_126866 is not reproducible when nested because of this...Tapping the screen moves the pointer to the tap location and triggers a pointer button press event there.
For example, https://source.puri.sm/Librem5/phosh/-/merge_requests/655#note_126866 is not reproducible when nested because of this, and it triggers hover as well.
phoc and phosh from master, Fedora 33.https://source.puri.sm/Librem5/wlroots/-/issues/38etnaviv: Crashes with two outputs when client binds wlr_output_management and...2020-09-21T10:32:48ZGuido Guntheretnaviv: Crashes with two outputs when client binds wlr_output_management and wlroots fails to bind the framebufferThis is phoc 0.4.2 with wlroots 0.11.0 (as currently in Debian):
```
Sep 11 20:24:36 pureos phosh[23307]: phoc: types/wlr_output_management_v1.c:690: head_send_state: Assertion `head->state.mode != NULL || wl_list_empty(&head->state.ou...This is phoc 0.4.2 with wlroots 0.11.0 (as currently in Debian):
```
Sep 11 20:24:36 pureos phosh[23307]: phoc: types/wlr_output_management_v1.c:690: head_send_state: Assertion `head->state.mode != NULL || wl_list_empty(&head->state.output->modes)' failed.
```
```
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x0000ffffb8a44de0 in __GI_abort () at abort.c:79
#2 0x0000ffffb8a51708 in __assert_fail_base (fmt=0xffffb8b4d560 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n",
assertion=assertion@entry=0xffffb8c6ab58 "head->state.mode != NULL || wl_list_empty(&head->state.output->modes)", file=file@entry=0xffffb8c6a980 "types/wlr_output_management_v1.c", line=line@entry=690,
function=function@entry=0xffffb8c6ad30 <__PRETTY_FUNCTION__.0> "head_send_state") at assert.c:92
#3 0x0000ffffb8a5176c in __GI___assert_fail (assertion=assertion@entry=0xffffb8c6ab58 "head->state.mode != NULL || wl_list_empty(&head->state.output->modes)",
file=file@entry=0xffffb8c6a980 "types/wlr_output_management_v1.c", line=line@entry=690, function=function@entry=0xffffb8c6ad30 <__PRETTY_FUNCTION__.0> "head_send_state") at assert.c:101
#4 0x0000ffffb8c45840 in head_send_state (head=0xaaaae055f7d0, head_resource=0xaaaae0b751a0, state=31) at protocol/wlr-output-management-unstable-v1-protocol.h:453
#5 0x0000ffffb8c45dbc in manager_bind (client=<optimized out>, data=0xaaaae04135e0, version=<optimized out>, id=<optimized out>) at ../types/wlr_output_management_v1.c:579
#6 0x0000ffffb8824e98 in ?? () from /usr/lib/aarch64-linux-gnu/libffi.so.7
#7 0x0000ffffb88245e0 in ?? () from /usr/lib/aarch64-linux-gnu/libffi.so.7
#8 0x0000ffffb8cb1a20 in wl_closure_invoke (closure=closure@entry=0xaaaae0b84010, flags=flags@entry=2, target=<optimized out>, opcode=0, data=<optimized out>, data@entry=0xaaaae0b73c00)
at ../src/connection.c:1018
#9 0x0000ffffb8cacd80 in wl_client_connection_data (fd=<optimized out>, mask=<optimized out>, data=0xaaaae0b73c00) at ../src/wayland-server.c:432
#10 0x0000ffffb8cafa68 in wl_event_loop_dispatch (loop=0xaaaadfdabe00, timeout=timeout@entry=0) at ../src/event-loop.c:1027
#11 0x0000aaaacff091bc in wayland_event_source_dispatch (base=<optimized out>, callback=<optimized out>, data=<optimized out>) at ../src/server.c:42
#12 0x0000ffffb8ed644c in g_main_context_dispatch () from /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0
#13 0x0000ffffb8ed66b8 in ?? () from /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0
#14 0x0000ffffb8ed69f8 in g_main_loop_run () from /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0
#15 0x0000aaaacff08ed8 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:137
```
It doesn't crash when clients don't bind that protocol, also doesn't happen on intel.https://source.puri.sm/Librem5/wlroots/-/issues/37drop drm enable/disable workaround2019-12-02T17:06:50ZGuido Guntherdrop drm enable/disable workaroundhttps://source.puri.sm/Librem5/wlroots/merge_requests/56 was a workaround, things will go more into the directon of https://github.com/swaywm/wlroots/pull/1891https://source.puri.sm/Librem5/wlroots/merge_requests/56 was a workaround, things will go more into the directon of https://github.com/swaywm/wlroots/pull/1891https://source.puri.sm/Librem5/wlroots/-/issues/34X11 backend: support high resolution scrolling2019-08-07T00:26:20ZSebastian KrzyszkowiakX11 backend: support high resolution scrollingI believe this is the only feature missing to make nested phoc on X11 feature complete (with one exception of pointer-gestures, as that can't really be implemented on X11 right now).I believe this is the only feature missing to make nested phoc on X11 feature complete (with one exception of pointer-gestures, as that can't really be implemented on X11 right now).https://source.puri.sm/Librem5/wlroots/-/issues/7Maintain input_method_secure patches2023-07-24T09:06:31ZDorota CzaplejewiczMaintain input_method_secure patchesThe code from https://source.puri.sm/Librem5/wlroots/commits/input_method_secure will not get merged to rootston upstream, and the maintainers refused it already. It's crucial to have input method support on any real device though. Until...The code from https://source.puri.sm/Librem5/wlroots/commits/input_method_secure will not get merged to rootston upstream, and the maintainers refused it already. It's crucial to have input method support on any real device though. Until a better method comes, these patches need to be applied on top of master.
Since I don't know how to do that properly, I'm filing an issue.A1: Support fully featured on screen keyboard