Commit 4a513b13 authored by Marek Vasut's avatar Marek Vasut Committed by Angus Ainslie
Browse files

redpine: Move card interrupt handling to RX thread

The interrupt handling of the RS911x is particularly heavy. For each RX
packet, the card does three SDIO transactions, one to read interrupt
status register, one to RX buffer length, one to read the RX packet(s).
This translates to ~330 uS per one cycle of interrupt handler. In case
there is more incoming traffic, this will be more.

The drivers/mmc/core/sdio_irq.c has the following comment, quote "Just
like traditional hard IRQ handlers, we expect SDIO IRQ handlers to be
quick and to the point, so that the holding of the host lock does not
cover too much work that doesn't require that lock to be held."

The RS911x interrupt handler does not fit that. This patch therefore
changes it such that the entire IRQ handler is moved to the RX thread
instead, and the interrupt handler only wakes the RX thread.

This is OK, because the interrupt handler only does things which can
also be done in the RX thread, that is, it checks for firmware loading
error(s), it checks buffer status, it checks whether a packet arrived
and if so, reads out the packet and passes it to network stack.

Moreover, this change permits removal of a code which allocated an
skbuff only to get 4-byte-aligned buffer, read up to 8kiB of data
into the skbuff, queue this skbuff into local private queue, then in
RX thread, this buffer is dequeued, the data in the skbuff as passed
to the RSI driver core, and the skbuff is deallocated. All this is
replaced by directly calling the RSI driver core with local buffer.
Signed-off-by: default avatarMarek Vasut <>
parent 4314a27f
Pipeline #62441 passed with stage
in 60 minutes and 51 seconds
......@@ -176,9 +176,7 @@ static void rsi_handle_interrupt(struct sdio_func *function)
if (adapter->priv->fsm_state == FSM_FW_NOT_LOADED)
dev->sdio_irq_task = current;
dev->sdio_irq_task = NULL;
static void rsi_gspi_init(struct rsi_hw *adapter)
......@@ -1192,9 +1190,9 @@ static int rsi_init_sdio_interface(struct rsi_hw *adapter,
adapter->determine_event_timeout = rsi_sdio_determine_event_timeout;
adapter->process_isr_hci = rsi_interrupt_handler;
adapter->process_isr_hci = rsi_rx_handler;
adapter->check_intr_status_reg = rsi_read_intr_status_reg;
adapter->num_debugfs_entries = MAX_DEBUGFS_ENTRIES;
......@@ -1294,8 +1292,6 @@ static int rsi_probe(struct sdio_func *pfunction,
redpine_dbg(ERR_ZONE, "%s: Unable to init rx thrd\n", __func__);
goto fail_kill_thread;
sdev->rx_q.num_rx_pkts = 0;
......@@ -74,13 +74,13 @@ int rsi_sdio_master_access_msword(struct rsi_hw *adapter,
return status;
void rsi_rx_handler(struct rsi_hw *adapter);
void rsi_sdio_rx_thread(struct rsi_common *common)
struct rsi_hw *adapter = common->priv;
struct rsi_91x_sdiodev *sdev = adapter->rsi_dev;
struct sk_buff *skb;
int status;
bool done = false;
do {
status = rsi_wait_event(&sdev->rx_thread.event,
......@@ -88,35 +88,11 @@ void rsi_sdio_rx_thread(struct rsi_common *common)
if (status < 0)
if (atomic_read(&sdev->rx_thread.thread_done))
while (true) {
skb = skb_dequeue(&sdev->rx_q.head);
if (!skb)
status = redpine_read_pkt(common, skb->data, skb->len);
if (status) {
redpine_dbg(ERR_ZONE, "Failed to read the packet\n");
if (sdev->rx_q.num_rx_pkts > 0)
if (atomic_read(&sdev->rx_thread.thread_done)) {
done = true;
if (done)
} while (1);
} while (!atomic_read(&sdev->rx_thread.thread_done));
redpine_dbg(INFO_ZONE, "%s: Terminated SDIO RX thread\n", __func__);
complete_and_exit(&sdev->rx_thread.completion, 0);
......@@ -138,10 +114,6 @@ static int rsi_process_pkt(struct rsi_common *common)
int status = 0;
u8 value = 0;
u8 protocol = 0, unaggr_pkt = 0;
struct sk_buff *skb;
if (dev->rx_q.num_rx_pkts >= RSI_SDIO_MAX_RX_PKTS)
return 0;
#define COEX_PKT 0
#define WLAN_PKT 3
......@@ -179,26 +151,19 @@ static int rsi_process_pkt(struct rsi_common *common)
unaggr_pkt = 1;
rcv_pkt_len = (num_blks * 256);
skb = dev_alloc_skb(rcv_pkt_len);
if (!skb) {
redpine_dbg(ERR_ZONE, "%s: Failed to allocate rx packet\n",
return -ENOMEM;
skb_put(skb, rcv_pkt_len);
status = rsi_sdio_host_intf_read_pkt(adapter, skb->data, skb->len);
status = rsi_sdio_host_intf_read_pkt(adapter, dev->pktbuffer, rcv_pkt_len);
if (status) {
redpine_dbg(ERR_ZONE, "%s: Failed to read packet from card\n",
return status;
skb_queue_tail(&dev->rx_q.head, skb);
status = redpine_read_pkt(common, dev->pktbuffer, rcv_pkt_len);
if (status) {
redpine_dbg(ERR_ZONE, "Failed to read the packet\n");
return status;
return 0;
......@@ -305,12 +270,12 @@ int rsi_read_intr_status_reg(struct rsi_hw *adapter)
* rsi_interrupt_handler() - This function read and process SDIO interrupts.
* rsi_rx_handler() - This function read and process SDIO interrupts.
* @adapter: Pointer to the adapter structure.
* Return: None.
void rsi_interrupt_handler(struct rsi_hw *adapter)
void rsi_rx_handler(struct rsi_hw *adapter)
struct rsi_common *common = adapter->priv;
struct rsi_91x_sdiodev *dev =
......@@ -124,12 +124,6 @@ struct receive_info {
u32 buf_available_counter;
struct rsi_sdio_rx_q {
u8 num_rx_pkts;
struct sk_buff_head head;
struct rsi_91x_sdiodev {
struct sdio_func *pfunction;
struct task_struct *sdio_irq_task;
......@@ -142,11 +136,11 @@ struct rsi_91x_sdiodev {
u32 tx_blk_size;
u8 write_fail;
u8 buff_status_updated;
struct rsi_sdio_rx_q rx_q;
struct rsi_thread rx_thread;
u8 pktbuffer[8192] __aligned(4);
void rsi_interrupt_handler(struct rsi_hw *adapter);
void rsi_rx_handler(struct rsi_hw *adapter);
int rsi_init_sdio_slave_regs(struct rsi_hw *adapter);
int rsi_sdio_device_init(struct rsi_common *common);
int rsi_sdio_read_register(struct rsi_hw *adapter, u32 addr, u8 *data);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment