Commit ec894b91 authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Greg Kroah-Hartman
Browse files

ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensor's bus

commit 8807d356 upstream.

GPIO lines for the CM36651 sensor I2C bus use the normal not the inverted
polarity. This bug has been there since adding the CM36651 sensor by
commit 85cb4e0b ("ARM: dts: add cm36651 light/proximity sensor node
for exynos4412-trats2"), but went unnoticed because the "i2c-gpio"
driver ignored the GPIO polarity specified in the device-tree.

The recent conversion of "i2c-gpio" driver to the new, descriptor based
GPIO API, automatically made it the DT-specified polarity aware, what
broke the CM36651 sensor operation.

Fixes: 85cb4e0b

 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2")
CC: # 4.16+
Signed-off-by: default avatarMarek Szyprowski <>
Signed-off-by: default avatarKrzysztof Kozlowski <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent fe75b26d
...@@ -68,7 +68,7 @@ ak8975@c { ...@@ -68,7 +68,7 @@ ak8975@c {
i2c_cm36651: i2c-gpio-2 { i2c_cm36651: i2c-gpio-2 {
compatible = "i2c-gpio"; compatible = "i2c-gpio";
gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>; gpios = <&gpf0 0 GPIO_ACTIVE_HIGH>, <&gpf0 1 GPIO_ACTIVE_HIGH>;
i2c-gpio,delay-us = <2>; i2c-gpio,delay-us = <2>;
#address-cells = <1>; #address-cells = <1>;
#size-cells = <0>; #size-cells = <0>;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment