• Joel Fernandes (Google)'s avatar
    mm: treewide: remove unused address argument from pte_alloc functions · bef22eb7
    Joel Fernandes (Google) authored
    Patch series "Add support for fast mremap"/
    
    This series speeds up the mremap(2) syscall by copying page tables at the
    PMD level even for non-THP systems.  There is concern that the extra
    'address' argument that mremap passes to pte_alloc may do something subtle
    architecture related in the future that may make the scheme not work.
    Also we find that there is no point in passing the 'address' to pte_alloc
    since its unused.  This patch therefore removes this argument tree-wide
    resulting in a nice negative diff as well.  Also ensuring along the way
    that the enabled architectures do not do anything funky with the 'address'
    argument that goes unnoticed by the optimization.
    
    Build and boot tested on x86-64.  Build tested on arm64.  The config
    enablement patch for arm64 will be posted in the future after more
    testing.
    
    The changes were obtained by applying the following Coccinelle script.
    (thanks Julia for answering all Coccinelle questions!).
    Following fix ups were done manually:
    * Removal of address argument from  pte_fragment_alloc
    * Removal of pte_alloc_one_fast definitions from m68k and microblaze.
    
    // Options: --include-headers --no-includes
    // Note: I split the 'identifier fn' line, so if you are manually
    // running it, please unsplit it so it runs for you.
    
    virtual patch
    
    @pte_alloc_func_def depends on patch exists@
    identifier E2;
    identifier fn =~
    "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$";
    type T2;
    @@
    
     fn(...
    - , T2 E2
     )
     { ... }
    
    @pte_alloc_func_proto_noarg depends on patch exists@
    type T1, T2, T3, T4;
    identifier fn =~ "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$";
    @@
    
    (
    - T3 fn(T1, T2);
    + T3 fn(T1);
    |
    - T3 fn(T1, T2, T4);
    + T3 fn(T1, T2);
    )
    
    @pte_alloc_func_proto depends on patch exists@
    identifier E1, E2, E4;
    type T1, T2, T3, T4;
    identifier fn =~
    "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$";
    @@
    
    (
    - T3 fn(T1 E1, T2 E2);
    + T3 fn(T1 E1);
    |
    - T3 fn(T1 E1, T2 E2, T4 E4);
    + T3 fn(T1 E1, T2 E2);
    )
    
    @pte_alloc_func_call depends on patch exists@
    expression E2;
    identifier fn =~
    "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$";
    @@
    
     fn(...
    -,  E2
     )
    
    @pte_alloc_macro depends on patch exists@
    identifier fn =~
    "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$";
    identifier a, b, c;
    expression e;
    position p;
    @@
    
    (
    - #define fn(a, b, c) e
    + #define fn(a, b) e
    |
    - #define fn(a, b) e
    + #define fn(a) e
    )
    
    Link: http://lkml.kernel.org/r/20181108181201.88826-2-joelaf@google.comSigned-off-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
    Suggested-by: default avatarKirill A. Shutemov <kirill@shutemov.name>
    Acked-by: default avatarKirill A. Shutemov <kirill@shutemov.name>
    Cc: Michal Hocko <mhocko@kernel.org>
    Cc: Julia Lawall <Julia.Lawall@lip6.fr>
    Cc: Kirill A. Shutemov <kirill@shutemov.name>
    Cc: William Kucharski <william.kucharski@oracle.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
    bef22eb7
Name
Last commit
Last update
..
boot Loading commit data...
common Loading commit data...
configs Loading commit data...
crypto Loading commit data...
firmware Loading commit data...
include Loading commit data...
kernel Loading commit data...
kvm Loading commit data...
lib Loading commit data...
mach-actions Loading commit data...
mach-alpine Loading commit data...
mach-artpec Loading commit data...
mach-asm9260 Loading commit data...
mach-aspeed Loading commit data...
mach-at91 Loading commit data...
mach-axxia Loading commit data...
mach-bcm Loading commit data...
mach-berlin Loading commit data...
mach-clps711x Loading commit data...
mach-cns3xxx Loading commit data...
mach-davinci Loading commit data...
mach-digicolor Loading commit data...
mach-dove Loading commit data...
mach-ebsa110 Loading commit data...
mach-efm32 Loading commit data...
mach-ep93xx Loading commit data...
mach-exynos Loading commit data...
mach-footbridge Loading commit data...
mach-gemini Loading commit data...
mach-highbank Loading commit data...
mach-hisi Loading commit data...
mach-imx Loading commit data...
mach-integrator Loading commit data...
mach-iop13xx Loading commit data...
mach-iop32x Loading commit data...
mach-iop33x Loading commit data...
mach-ixp4xx Loading commit data...
mach-keystone Loading commit data...
mach-ks8695 Loading commit data...
mach-lpc18xx Loading commit data...
mach-lpc32xx Loading commit data...
mach-mediatek Loading commit data...
mach-meson Loading commit data...
mach-mmp Loading commit data...
mach-moxart Loading commit data...
mach-mv78xx0 Loading commit data...
mach-mvebu Loading commit data...
mach-mxs Loading commit data...
mach-netx Loading commit data...
mach-nomadik Loading commit data...
mach-npcm Loading commit data...
mach-nspire Loading commit data...
mach-omap1 Loading commit data...
mach-omap2 Loading commit data...
mach-orion5x Loading commit data...
mach-oxnas Loading commit data...
mach-picoxcell Loading commit data...
mach-prima2 Loading commit data...
mach-pxa Loading commit data...
mach-qcom Loading commit data...
mach-realview Loading commit data...
mach-rockchip Loading commit data...
mach-rpc Loading commit data...
mach-s3c24xx Loading commit data...
mach-s3c64xx Loading commit data...
mach-s5pv210 Loading commit data...
mach-sa1100 Loading commit data...
mach-shmobile Loading commit data...
mach-socfpga Loading commit data...
mach-spear Loading commit data...
mach-sti Loading commit data...
mach-stm32 Loading commit data...
mach-sunxi Loading commit data...
mach-tango Loading commit data...
mach-tegra Loading commit data...
mach-u300 Loading commit data...
mach-uniphier Loading commit data...
mach-ux500 Loading commit data...
mach-versatile Loading commit data...
mach-vexpress Loading commit data...
mach-vt8500 Loading commit data...
mach-w90x900 Loading commit data...
mach-zx Loading commit data...
mach-zynq Loading commit data...
mm Loading commit data...
net Loading commit data...
nwfpe Loading commit data...
oprofile Loading commit data...
plat-iop Loading commit data...
plat-omap Loading commit data...
plat-orion Loading commit data...
plat-pxa Loading commit data...
plat-samsung Loading commit data...
plat-versatile Loading commit data...
probes Loading commit data...
tools Loading commit data...
vdso Loading commit data...
vfp Loading commit data...
xen Loading commit data...
Kconfig Loading commit data...
Kconfig-nommu Loading commit data...
Kconfig.debug Loading commit data...
Makefile Loading commit data...
arm-soc-for-next-contents.txt Loading commit data...