Commit 826a5cd4 authored by Bjorn Andersson's avatar Bjorn Andersson
Browse files

firehose: Send ZLP after each chunk

It was assumed that we should send all the data following a "program"
request to the device, before sending a ZLP. But on SDM845 it's seen
that not sending a ZLP after each chunk sometimes causes the
communication to stall.

Given that the "program" request already carries the information about
how much data will be transferred there should be no issues with sending
additional ZLPs, so do this.
Signed-off-by: default avatarBjorn Andersson <>
parent 8f7987f7
......@@ -378,7 +378,7 @@ static int firehose_program(struct qdl_device *qdl, struct program *program, int
if (n < max_payload_size)
memset(buf + n, 0, max_payload_size - n);
n = qdl_write(qdl, buf, chunk_size * program->sector_size, left == chunk_size);
n = qdl_write(qdl, buf, chunk_size * program->sector_size, true);
if (n < 0)
err(1, "failed to write");
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment