Skip to content
  • Linus Torvalds's avatar
    Revert "[PATCH] fix Data Acess error in dup_fd" · 9a3a04ac
    Linus Torvalds authored
    This reverts commit 0130b0b3
    
    .
    
    Sergey Vlasov points out (and Vadim Lobanov concurs) that the bug it was
    supposed to fix must be some unrelated memory corruption, and the "fix"
    actually causes more problems:
    
      "However, the new code does not look safe in all cases.  If some other
       task has opened more files while dup_fd() released oldf->file_lock, the
       new code will update open_files to the new larger value.  But newf was
       allocated with the old smaller value of open_files, therefore subsequent
       accesses to newf may try to write into unallocated memory."
    
    so revert it.
    
    Cc: Sharyathi Nagesh <sharyath@in.ibm.com>
    Cc: Sergey Vlasov <vsu@altlinux.ru>
    Cc: Vadim Lobanov <vlobanov@speakeasy.net>
    Cc: Andrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    9a3a04ac