Skip to content
  • Carsten Emde's avatar
    tracing: Remove comparing of NULL to va_list in trace_array_vprintk() · f2942487
    Carsten Emde authored
    Olof Johansson stated the following:
    
      Comparing a va_list with NULL is bogus. It's supposed to be treated like
      an opaque type and only be manipulated with va_* accessors.
    
    Olof noticed that this code broke the ARM builds:
    
        kernel/trace/trace.c: In function 'trace_array_vprintk':
        kernel/trace/trace.c:1364: error: invalid operands to binary == (have 'va_list' and 'void *')
        kernel/trace/trace.c: In function 'tracing_mark_write':
        kernel/trace/trace.c:3349: error: incompatible type for argument 3 of 'trace_vprintk'
    
    This patch partly reverts c13d2f7c
    
     and
    re-installs the original mark_printk() mechanism.
    
    Reported-by: default avatarOlof Johansson <olof@lixom.net>
    Signed-off-by: default avatarCarsten Emde <C.Emde@osadl.org>
    LKML-Reference: <4B1BAB74.104@osadl.org>
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    f2942487