Commit 041bd12e authored by Tejun Heo's avatar Tejun Heo

Revert "workqueue: make sure delayed work run in local cpu"

This reverts commit 874bbfe6.

Workqueue used to implicity guarantee that work items queued without
explicit CPU specified are put on the local CPU.  Recent changes in
timer broke the guarantee and led to vmstat breakage which was fixed
by 176bed1d ("vmstat: explicitly schedule per-cpu work on the CPU
we need it to run on").

vmstat is the most likely to expose the issue and it's quite possible
that there are other similar problems which are a lot more difficult
to trigger.  As a preventive measure, 874bbfe6 ("workqueue: make
sure delayed work run in local cpu") was applied to restore the local
CPU guarnatee.  Unfortunately, the change exposed a bug in timer code
which got fixed by 22b886dd ("timers: Use proper base migration in
add_timer_on()").  Due to code restructuring, the commit couldn't be
backported beyond certain point and stable kernels which only had
874bbfe6 started crashing.

The local CPU guarantee was accidental more than anything else and we
want to get rid of it anyway.  As, with the vmstat case fixed,
874bbfe6 is causing more problems than it's fixing, it has been
decided to take the chance and officially break the guarantee by
reverting the commit.  A debug feature will be added to force foreign
CPU assignment to expose cases relying on the guarantee and fixes for
the individual cases will be backported to stable as necessary.
Signed-off-by: default avatarTejun Heo <>
Fixes: 874bbfe6 ("workqueue: make sure delayed work run in local cpu")
Cc: Mike Galbraith <>
Cc: Henrique de Moraes Holschuh <>
Cc: Daniel Bilik <>
Cc: Jan Kara <>
Cc: Shaohua Li <>
Cc: Sasha Levin <>
Cc: Ben Hutchings <>
Cc: Thomas Gleixner <>
Cc: Daniel Bilik <>
Cc: Jiri Slaby <>
Cc: Michal Hocko <>
parent 23d11a58
......@@ -1464,13 +1464,13 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq,
dwork->wq = wq;
/* timer isn't guaranteed to run in this cpu, record earlier */
if (cpu == WORK_CPU_UNBOUND)
cpu = raw_smp_processor_id();
dwork->cpu = cpu;
timer->expires = jiffies + delay;
add_timer_on(timer, cpu);
if (unlikely(cpu != WORK_CPU_UNBOUND))
add_timer_on(timer, cpu);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment