Commit 2e00c97e authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Christoph Hellwig
Browse files

vfs: add __destroy_inode

When we want to tear down an inode that lost the add to the cache race
in XFS we must not call into ->destroy_inode because that would delete
the inode that won the race from the inode cache radix tree.

This patch provides the __destroy_inode helper needed to fix this,
the actual fix will be in th next patch.  As XFS was the only reason
destroy_inode was exported we shift the export to the new __destroy_inode.
Signed-off-by: default avatarChristoph Hellwig <>
Reviewed-by: default avatarEric Sandeen <>
parent 54e34621
......@@ -229,7 +229,7 @@ static struct inode *alloc_inode(struct super_block *sb)
return inode;
void destroy_inode(struct inode *inode)
void __destroy_inode(struct inode *inode)
......@@ -241,13 +241,17 @@ void destroy_inode(struct inode *inode)
if (inode->i_default_acl && inode->i_default_acl != ACL_NOT_CACHED)
void destroy_inode(struct inode *inode)
if (inode->i_sb->s_op->destroy_inode)
kmem_cache_free(inode_cachep, (inode));
* These are initializations that only need to be done
......@@ -2164,6 +2164,7 @@ extern void __iget(struct inode * inode);
extern void iget_failed(struct inode *);
extern void clear_inode(struct inode *);
extern void destroy_inode(struct inode *);
extern void __destroy_inode(struct inode *);
extern struct inode *new_inode(struct super_block *);
extern int should_remove_suid(struct dentry *);
extern int file_remove_suid(struct file *);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment