Commit 47ac7666 authored by Mark's avatar Mark Committed by Greg Kroah-Hartman
Browse files

tty: serial: 8250: Revert NXP SC16C2552 workaround

Revert commit ecb988a3

: tty: serial:
8250: 8250_core: NXP SC16C2552 workaround

The above commit causes userland application to no longer write
correctly its first write to a dumb terminal connected to /dev/ttyS0.
This commit seems to be the culprit. It's as though the TX FIFO is being
reset during that write. What should be displayed is:

PSW 80000000 INST 00000000                           HALT

What is displayed is some variation of:

T 00000000           HAL//

Reverting this commit via this patch fixes my problem.
Signed-off-by: default avatarMark Hounschell <>
Fixes: ecb988a3

 ("tty: serial: 8250: 8250_core: NXP SC16C2552 workaround")
Cc: stable <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 60ab0faf
......@@ -90,8 +90,7 @@ static const struct serial8250_config uart_config[] = {
.name = "16550A",
.fifo_size = 16,
.tx_loadsz = 16,
.rxtrig_bytes = {1, 4, 8, 14},
.flags = UART_CAP_FIFO,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment