Commit 5017335d authored by Fabian Frederick's avatar Fabian Frederick Committed by Linus Torvalds
Browse files

scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning



if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition.  The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.

With inspiration from Bruce Fields.
Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
Suggested-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Cc: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 97534127
...@@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON") ...@@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON")
p << r.p; p << r.p;
@@ @@
msg="WARNING: Use BUG_ON" msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)"
coccilib.report.print_report(p[0], msg) coccilib.report.print_report(p[0], msg)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment