Commit aa2be9b3 authored by Daniel Axtens's avatar Daniel Axtens Committed by Herbert Xu
Browse files

crypto: powerpc - Fix initialisation of crc32c context

Turning on crypto self-tests on a POWER8 shows:

    alg: hash: Test 1 failed for crc32c-vpmsum
    00000000: ff ff ff ff

Comparing the code with the Intel CRC32c implementation on which
ours is based shows that we are doing an init with 0, not ~0
as CRC32c requires.

This probably wasn't caught because btrfs does its own weird
open-coded initialisation.

Initialise our internal context to ~0 on init.

This makes the self-tests pass, and btrfs continues to work.

Fixes: 6dd7a82c

 ("crypto: powerpc - Add POWER8 optimised crc32c")
Cc: Anton Blanchard <>
Signed-off-by: default avatarDaniel Axtens <>
Acked-by: default avatarAnton Blanchard <>
Signed-off-by: default avatarHerbert Xu <>
parent c1ae3cfa
......@@ -52,7 +52,7 @@ static int crc32c_vpmsum_cra_init(struct crypto_tfm *tfm)
u32 *key = crypto_tfm_ctx(tfm);
*key = 0;
*key = ~0;
return 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment