Skip to content
  • Nicolas Dichtel's avatar
    rtnl/bond: don't send rtnl msg for unregistered iface · ed2a80ab
    Nicolas Dichtel authored
    Before the patch, the command 'ip link add bond2 type bond mode 802.3ad'
    causes the kernel to send a rtnl message for the bond2 interface, with an
    ifindex 0.
    
    'ip monitor' shows:
    0: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 state DOWN group default
        link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
    9: bond2@NONE: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default
        link/ether ea:3e:1f:53:92:7b brd ff:ff:ff:ff:ff:ff
    [snip]
    
    The patch fixes the spotted bug by checking in bond driver if the interface
    is registered before calling the notifier chain.
    It also adds a check in rtmsg_ifinfo() to prevent this kind of bug in the
    future.
    
    Fixes: d4261e56
    
     ("bonding: create netlink event when bonding option is changed")
    CC: Jiri Pirko <jiri@resnulli.us>
    Reported-by: default avatarJulien Meunier <julien.meunier@6wind.com>
    Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ed2a80ab