Skip to content
  • Arnaldo Carvalho de Melo's avatar
    perf hists browser: Remove leftover from row returned from refresh · 94e87a8b
    Arnaldo Carvalho de Melo authored
    The per-browser screen refresh routine (ui_browser->refresh()) should
    return the first row that should be cleaned after the rows just printed,
    in case not all rows available on the screen gets filled.
    
    When moving the extra title lines logic from the hists browser to the
    generic ui_browser class, one piece of that logic remained in the hists
    browser and then when going back from the annotate browser to the hists
    browser in a case where fewer lines were displayed in the hists browser,
    for instance when filtering the entries per substring, one line of the
    annotate browser would remain on the screen, fix that.
    
    Example of the screen artifact:
    
    ================================================================================
    Samples: 73K of event 'cycles:ppp', 4000 Hz, Event count (approx.): 45172901394
    Overhead  Shared O  Symbol
       0.30%  [kernel]  [k] __indirect_thunk_start
       0.09%  [kernel]  [k] __x86_indirect_thunk_r10
           │      lfence
    ================================================================================
    
    Here from 'perf top' the view was zoomed with '/thunk' to functions
    having that substring, then the first was annotated and from the
    annotate browser ESC was pressed, then the first lines were overwritten,
    but the 'lfence' line remained due to the off by one bug fixed in this
    cset.
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Fixes: ef9ff601 ("perf ui browser: Move the extra title lines from the hists browser")
    Link: https://lkml.kernel.org/n/tip-odryfso74eaarm0z3e4v9owx@git.kernel.org
    
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    94e87a8b