Skip to content
  • Satyam Sharma's avatar
    [PATCH] configfs+dlm: Rename config_group_find_obj and state semantics clearly · 3fe6c5ce
    Satyam Sharma authored
    Configfs being based upon sysfs code, config_group_find_obj() is probably
    so named because of the similar kset_find_obj() in sysfs. However,
    "kobject"s in sysfs become "config_item"s in configfs, so let's call it
    config_group_find_item() instead, for sake of uniformity, and make
    corresponding change in the users of this function.
    
    BTW a crucial difference between kset_find_obj and config_group_find_item
    is in locking expectations. kset_find_obj does its locking by itself, but
    config_group_find_item expects the *caller* to do the locking. The reason
    for this: kset's have their own locks, config_group's don't but instead
    rely on the subsystem mutex. And, subsystem needn't necessarily be around
    when config_group_find_item() is called.
    
    So let's state these locking semantics explicitly, and rectify the comment,
    otherwise bugs could continue to occur in future, as they did in the past
    (refer commit d82b8191e238 in gfs2-2.6-fixes.git).
    
    [ I also took the opportunity to fix some bad whitespace and
    double-empty lines. --Joel ]
    
    [ Conflict in fs/dlm/config.c with commit
      3168b078
    
     manually resolved. --Mark ]
    
    Signed-off-by: default avatarSatyam Sharma <ssatyam@cse.iitk.ac.in>
    Cc: David Teigland <teigland@redhat.com>
    Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
    Signed-off-by: default avatarMark Fasheh <mark.fasheh@oracle.com>
    3fe6c5ce