• Vlad Yasevich's avatar
    vlan: Fix tcp checksum offloads in Q-in-Q vlans · 35d2f80b
    Vlad Yasevich authored
    It appears that TCP checksum offloading has been broken for
    Q-in-Q vlans.  The behavior was execerbated by the
        commit afb0bc97 ("Merge branch 'stacked_vlan_tso'")
    that that enabled accleleration features on stacked vlans.
    However, event without that series, it is possible to trigger
    this issue.  It just requires a lot more specialized configuration.
    The root cause is the interaction between how
    netdev_intersect_features() works, the features actually set on
    the vlan devices and HW having the ability to run checksum with
    longer headers.
    The issue starts when netdev_interesect_features() replaces
    NETIF_F_HW_CSUM with a combination of NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM,
    if the HW advertises IP|IPV6 specific checksums.  This happens
    for tagged and multi-tagged packets.   However, HW that enables
    IP|IPV6 checksum offloading doesn't gurantee that packets with
    arbitrarily long headers can be checksummed.
    This patch disables IP|IPV6 checksums on the packet for multi-tagged
    CC: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
    CC: Michal Kubecek <mkubecek@suse.cz>
    Signed-off-by: default avatarVladislav Yasevich <vyasevic@redhat.com>
    Acked-by: default avatarToshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
if_vlan.h 16.8 KB