Skip to content
  • Yan, Zheng's avatar
    libceph: call r_unsafe_callback when unsafe reply is received · 61c5d6bf
    Yan, Zheng authored
    
    
    We can't use !req->r_sent to check if OSD request is sent for the
    first time, this is because __cancel_request() zeros req->r_sent
    when OSD map changes. Rather than adding a new variable to struct
    ceph_osd_request to indicate if it's sent for the first time, We
    can call the unsafe callback only when unsafe OSD reply is received.
    If OSD's first reply is safe, just skip calling the unsafe callback.
    
    The purpose of unsafe callback is adding unsafe request to a list,
    so that fsync(2) can wait for the safe reply. fsync(2) doesn't need
    to wait for a write(2) that hasn't returned yet. So it's OK to add
    request to the unsafe list when the first OSD reply is received.
    (ceph_sync_write() returns after receiving the first OSD reply)
    
    Signed-off-by: default avatarYan, Zheng <zheng.z.yan@intel.com>
    Reviewed-by: default avatarSage Weil <sage@inktank.com>
    61c5d6bf